Skip to content

update mockgen to 1.4.3#3379

Merged
stevendanna merged 1 commit intomasterfrom
ssd/update-mockgen
Apr 16, 2020
Merged

update mockgen to 1.4.3#3379
stevendanna merged 1 commit intomasterfrom
ssd/update-mockgen

Conversation

@stevendanna
Copy link
Copy Markdown
Contributor

This release of mockgen has an important speed improvement:

golang/mock#397

On linux, with tools already installed and a primed cache, we go from:

> time compile_client_mocks
...
real	0m55.859s
user	1m39.088s
sys 	1m40.395s

to

> time compile_client_mocks
...
real	0m9.133s
user	0m12.420s
sys 	0m7.568s

Unfortunately, on macOS+Docker, the impact isn't as dramatic:

> time compile_client_mocks
...
real	1m32.170s
user	1m46.861s
sys 	2m31.633s

to

> time compile_client_mocks
...
real	1m8.510s
user	0m21.225s
sys 	0m24.807s

Signed-off-by: Steven Danna [email protected]

This release of mockgen has an important speed improvement:

 golang/mock#397

On linux, with tools already installed and a primed cache, we go from:

    > time compile_client_mocks
    ...
    real	0m55.859s
    user	1m39.088s
    sys 	1m40.395s

to

    > time compile_client_mocks
    ...
    real	0m9.133s
    user	0m12.420s
    sys 	0m7.568s

Unfortunately, on macOS+Docker, the impact isn't as dramatic:

    > time compile_client_mocks
    ...
    real	1m32.170s
    user	1m46.861s
    sys 	2m31.633s

to

    > time compile_client_mocks
    ...
    real	1m8.510s
    user	0m21.225s
    sys 	0m24.807s

Signed-off-by: Steven Danna <[email protected]>
Copy link
Copy Markdown
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stevendanna
Copy link
Copy Markdown
Contributor Author

The massive line increase is mostly from:

 vendor/golang.org/x/net/idna/tables12.00.go                                 | 4733 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

@stevendanna stevendanna merged commit 2973259 into master Apr 16, 2020
@chef-expeditor chef-expeditor bot deleted the ssd/update-mockgen branch April 16, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants