Issue #14194: Add LexicographicalAnnotationListing
#17892
Conversation
Pankraz76
force-pushed
the
fix-error-prone-fix-maven
branch
from
2e42eff to
e3302cb
Compare
rickie
left a comment
rickie
left a comment
There was a problem hiding this comment.
Although sorting is good to do, we used the approach of enabling simply 1 check per pull request. We should probably do the same approach.
Additionally there should be some form of discussion on which rules to enable before simply doing it.
pom.xml
Outdated
| -Xep:RedundantStringConversion:ERROR | ||
| -Xep:RedundantStringEscape:ERROR | ||
| -Xep:Slf4jLogStatement:ERROR | ||
| -Xep:StaticImport:ERROR |
There was a problem hiding this comment.
Can drop this if we in the line after simply turn it off again.
pom.xml
Outdated
| -Xep:MockitoMockClassReference:ERROR | ||
| -Xep:MockitoStubbing:ERROR | ||
| -Xep:NestedOptionals:ERROR | ||
| -Xep:NonEmptyMono:ERROR |
There was a problem hiding this comment.
NonEmptyMono is a check for Reactor code, that's not necessary for this codebase.
There was a problem hiding this comment.
we found it conveninent to reference all validaiton modules that tool provides and just doe OFF for some rules and having comment above to explain why not use it.
in this case even in few years we can check list of used rules against tool documentation and see what is missed to be activated and what is deactivated for a reason.
Pankraz76
force-pushed
the
fix-error-prone-fix-maven
branch
from
e3302cb to
6022860
Compare
|
@Pankraz76 , please fix other violations and we good to merge. |
Pankraz76
force-pushed
the
fix-error-prone-fix-maven
branch
from
6022860 to
890d488
Compare
Pankraz76
force-pushed
the
fix-error-prone-fix-maven
branch
from
890d488 to
334aba8
Compare
|
We really need to address the patching process afterward to avoid the added price for this feature. We should improve acceptance through automation. |
|
thanks for the quick-win. |
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
Thanks a lot for keeping PR small and single point of fix, it helps a lot to accept it quickly
3 participants
Issue #14194: Add
LexicographicalAnnotationListingrelates to:
LexicographicalAnnotationAttributeListingjunit-team/junit-framework#5043