Issue #17717: Added checkstyle-openrewrite-recipes #17741

Anmol202005 · 2025-09-04T14:10:43Z

Fixes: #17717

Anmol202005 · 2025-09-04T17:47:52Z

@romani @rdiachenko kindly review.

Anmol202005 · 2025-09-04T18:07:57Z

@romani @rdiachenko
Kindly help with the CI here.

romani

Items

pom.xml

.circleci/config.yml

rewrite.yml

rdiachenko · 2025-09-05T19:49:17Z

@Anmol202005 also please fix ci/circleci: run-inspections, here's the reason:

<problems is_local_tool="true">
<problem>
<file>file://$PROJECT_DIR$/config/checkstyle.properties</file>
<line>1</line>
<module>project</module>
<entry_point TYPE="file" FQNAME="file://$PROJECT_DIR$/config/checkstyle.properties"/>
<problem_class id="AlphaUnsortedPropertiesFile" severity="ERROR" attribute_key="ERRORS_ATTRIBUTES">
Properties file or resource bundle is alphabetically unsorted
</problem_class>
<description>Properties file is alphabetically unsorted</description>
<highlighted_element>
checkstyle.cache.file=${mvn.project.build.directory}/cachefile checkstyle.header.file=config/java.he...
</highlighted_element>
<language>Properties</language>
<offset>0</offset>
<length>444</length>
</problem>
</problems>

Regarding Check PR Description, I approved the issue, so this should be fixed

romani

items:

.circleci/config.yml

romani · 2025-09-05T20:35:56Z

https://app.circleci.com/pipelines/github/checkstyle/checkstyle/36394/workflows/f44ba7ae-00a4-4d96-abb8-a8b14a428dda/jobs/1061403?invite=true#step-103-12965_56

./.ci/validation.sh no-exception-alot-of-projects
....
Running Checkstyle on src/main/java ... with excludes {}
mvn -e --no-transfer-progress --batch-mode site -Dcheckstyle.config.location=checks-nonjavadoc-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=1.0.0-SNAPSHOT -Dcheckstyle.failsOnError=false
Running command: mvn -e --no-transfer-progress --batch-mode site -Dcheckstyle.config.location=checks-nonjavadoc-error.xml -Dcheckstyle.excludes= -Dcheckstyle.version=1.0.0-SNAPSHOT -Dcheckstyle.failsOnError=false

-Dcheckstyle.version=1.0.0-SNAPSHOT this is deinetely wrong.

sounds like we messed up fodlers of clone, see item to improve bellow.

romani

items:

.circleci/config.yml

romani · 2025-09-05T20:57:40Z

group ID should be fixed for autofix project.

Anmol202005 · 2025-09-05T23:10:41Z

@romani @rdiachenko found the cause of error: https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/diff.groovy#L209

romani · 2025-09-05T23:22:27Z

Please send PR to fix groovy regexp to be more explicit

romani · 2025-09-05T23:27:52Z

Better idea, please move auto fix version to property of pom.xml, so groovy will not catch it.

romani

Items

rewrite.yml

Anmol202005 · 2025-09-07T07:35:29Z

@romani done.

romani · 2025-09-07T13:58:26Z

src/main/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask.java

    @Override
    public void execute() {
-        final long startTime = System.currentTimeMillis();
+        long startTime = System.currentTimeMillis();


lets see how CI will detect missing "final"

it works !!!
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/36437/workflows/b90cac5a-2135-4410-ad9d-386ac858386d/jobs/1063525?invite=true#step-103-29917_17

Anmol202005 · 2025-09-07T14:12:34Z

@romani i gguess i missed one cmd to run checkstyle first.
lets add that to the config and test it. on it.
IDK how it got removed.

romani · 2025-09-07T14:23:15Z

I removed it, I am testing, restored.
Works fine on local, lets see how cI works now

romani

ok to merge !

rdiachenko

lgtm

romani · 2025-09-07T16:21:36Z

CI failure:

�[0;32mrewrite:6.17.0:run�[m �[1m(default-cli)�[m @ �[36mcheckstyle�[0;1m ---�[m
[�[1;34mINFO�[m] Using active recipe(s) [CheckstyleAutoFix]
[�[1;34mINFO�[m] Using active styles(s) []
[�[1;34mINFO�[m] Validating active recipes...
[�[1;34mINFO�[m] Project [checkstyle] Resolving Poms...
[�[1;34mINFO�[m] Project

Restarted

Restarted again.

romani

Very good for first step

Pankraz76 · 2025-09-07T21:14:00Z

pom.xml

    <maven.versions.plugin.version>2.19.0</maven.versions.plugin.version>
    <maven.compiler.plugin.version>3.14.0</maven.compiler.plugin.version>
    <checkstyle.skipCompileInputResources>true</checkstyle.skipCompileInputResources>
+    <checkstyle.openrewrite.version>1.0.0-SNAPSHOT</checkstyle.openrewrite.version>


nearby release would help users to find version quicker.

Pankraz76 · 2025-09-07T21:43:05Z

.ci/validation.sh

+  ./mvnw -e --no-transfer-progress -Drewrite.recipeChangeLogLevel=INFO \
+  rewrite:run -P checkstyle-autofix
+
+  echo "Checking for uncommitted changes..."


in rare cases it would actually fail, even when passing here, laking flaky state to prod.

would need to run twice to really make sure, as big changes/recipes sometimes need multiple runs mostly twice just.

17 migration changes from javax to jarkata having the need to reorder/run imports, after initial run/migration.

Issue #17487: Add Rewrite:UpgradeToJava17 #17730

Just some idea, no big deal as simple rerun will fix it.

Anmol202005 marked this pull request as draft September 4, 2025 14:13

Anmol202005 force-pushed the rewrite branch from 3e4d014 to 5a9ab1d Compare September 4, 2025 17:42

Anmol202005 marked this pull request as ready for review September 4, 2025 17:47

romani requested changes Sep 5, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

pom.xml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

.circleci/config.yml Outdated Show resolved Hide resolved

Anmol202005 force-pushed the rewrite branch 5 times, most recently from 8cfbc97 to e2b6660 Compare September 5, 2025 18:20

rdiachenko reviewed Sep 5, 2025

View reviewed changes

rewrite.yml Outdated Show resolved Hide resolved

Anmol202005 mentioned this pull request Sep 5, 2025

Updated version from 1.0.0 to 1.0.0-SNAPSHOT checkstyle/checkstyle-openrewrite-recipes#108

Merged

Anmol202005 force-pushed the rewrite branch 2 times, most recently from d723278 to 374daef Compare September 5, 2025 20:13

romani requested changes Sep 5, 2025

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

romani requested changes Sep 5, 2025

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Anmol202005 force-pushed the rewrite branch 3 times, most recently from b60688b to 4e4b806 Compare September 5, 2025 22:41

Anmol202005 force-pushed the rewrite branch from 4e4b806 to 6d77980 Compare September 5, 2025 23:14

romani requested changes Sep 5, 2025

View reviewed changes

rewrite.yml Outdated Show resolved Hide resolved

rewrite.yml Show resolved Hide resolved

Anmol202005 force-pushed the rewrite branch 2 times, most recently from 988239f to ef08198 Compare September 6, 2025 18:08

romani force-pushed the rewrite branch from aab3c7f to 4c858dc Compare September 7, 2025 13:51

romani reviewed Sep 7, 2025

View reviewed changes

romani force-pushed the rewrite branch from 73e0538 to e8bfe8c Compare September 7, 2025 14:05

romani force-pushed the rewrite branch from e8bfe8c to 0e60ed9 Compare September 7, 2025 14:21

romani force-pushed the rewrite branch from 0e60ed9 to 87c71ca Compare September 7, 2025 14:30

romani approved these changes Sep 7, 2025

View reviewed changes

romani assigned rdiachenko Sep 7, 2025

rdiachenko approved these changes Sep 7, 2025

View reviewed changes

Anmol202005 force-pushed the rewrite branch 3 times, most recently from 975a409 to 510f80d Compare September 7, 2025 18:04

Issue checkstyle#17717: Added checkstyle-openrewrite-recipes

f0b2121

Anmol202005 force-pushed the rewrite branch from 510f80d to f0b2121 Compare September 7, 2025 18:09

rdiachenko assigned romani and unassigned rdiachenko Sep 7, 2025

romani approved these changes Sep 7, 2025

View reviewed changes

romani merged commit b587481 into checkstyle:master Sep 7, 2025
120 checks passed

Pankraz76 mentioned this pull request Sep 3, 2025

Add rewrite support for errorprone.refasterrules #17487

Closed

Pankraz76 reviewed Sep 7, 2025

View reviewed changes

Pankraz76 mentioned this pull request Sep 24, 2025

Add rewrite support for errorprone.refasterrules diffplug/spotless#2634

Closed

Uh oh!

Issue #17717: Added checkstyle-openrewrite-recipes #17741

Issue #17717: Added checkstyle-openrewrite-recipes #17741

Uh oh!

Conversation

Anmol202005 commented Sep 4, 2025

Uh oh!

Anmol202005 commented Sep 4, 2025

Uh oh!

Anmol202005 commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdiachenko commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romani commented Sep 5, 2025

Uh oh!

Anmol202005 commented Sep 5, 2025

Uh oh!

romani commented Sep 5, 2025

Uh oh!

romani commented Sep 5, 2025

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Anmol202005 commented Sep 7, 2025

Uh oh!

romani Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

romani Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Anmol202005 commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Sep 7, 2025

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

rdiachenko left a comment

Choose a reason for hiding this comment

Uh oh!

romani commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pankraz76 Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Anmol202005 commented Sep 4, 2025 •

edited

Loading

rdiachenko commented Sep 5, 2025 •

edited

Loading

romani commented Sep 5, 2025 •

edited

Loading

Anmol202005 commented Sep 7, 2025 •

edited

Loading

romani commented Sep 7, 2025 •

edited

Loading

Pankraz76 Sep 7, 2025 •

edited

Loading