-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Issue #17487: Add Rewrite:UpgradeToJava17
#17730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #17487: Add Rewrite:UpgradeToJava17
#17730
Conversation
src/main/java/com/puppycrawl/tools/checkstyle/gui/ParseTreeTablePresentation.java
Show resolved
Hide resolved
67e64f3 to
6fa6630
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
6fa6630 to
5f6033d
Compare
|
current checkstyle config goes again java convention: Disallowed import - jakarta.annotation.Nullable. [ImportControlMain] why so? this needs to be solved first. |
5f6033d to
8a6fe2b
Compare
This comment was marked as spam.
This comment was marked as spam.
458f2f1 to
f85ba24
Compare
|
@Pankraz76 , FYI, we merged most initial rewrite config, please rebase |
|
thank you so much. Teamwork makes the dream work. |
4703948 to
595cd41
Compare
6d3d1ab to
8ab0cef
Compare
8ab0cef to
b7e208c
Compare
105d62b to
f9fcab5
Compare
649fe5a to
34eea75
Compare
34eea75 to
0a1be48
Compare
|
Please use in commit reference to some issue that is related to openrewire updates |
69efb5f to
b4534aa
Compare
Rewrite:UpgradeToJava17Rewrite:UpgradeToJava17
b4534aa to
f8a73d4
Compare
|
Conflict |
f8a73d4 to
c0bf782
Compare
|
rebase |
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last:
| * @param value the value to get the int stream from. | ||
| * @return the int stream. | ||
| * @noinspectionreason ChainOfInstanceofChecks - We will deal with this at | ||
| * <a href="https://github.com/checkstyle/checkstyle/issues/13500">13500</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit weird, as IDEA use @noinspection tag, and you do not use it.
@noinspectionreason is checkstyle specific javadoc tag to keep context why suppression happened.
this means that IDEA inspection might not complain on this code any more, can you try to remove it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduced to @noinspection ChainOfInstanceofChecks like other usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes need it to make CI happy.
just c&p and we good to go.
good teamwork, thanks.
[ERROR] [checkstyle] [ERROR] /home/circleci/project/src/main/java/com/puppycrawl/tools/checkstyle/site/SiteUtil.java:1103:7: @noinspection Javadoc tags should be accompanied by a @noinspectionreason tag, explaining why we suppressed inspection. [MatchXpath]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both should be used.
But try without all first, looks like idea inspection are complaining in this any more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short: No. Its working and we are off topic losing focus on random experiments checking CI or idea both outside of tickets scope.
Merge or i will close, have invested enough on this already.
Long:
Both are already in use as required. We have failed multiple times having every variant, which is very annoying and makes me want to reject this.
I don't see the need to investigate why it works now or why it doesn't in other cases. These details aren't relevant.
We haven't eliminated all variants yet, and asking for more iterations is wasting time:
- none
- one
- just the reason
- just the marker
There's no value in repeating these redundancies expecting different results from the current state.
Let's consider experiments later. This feature has been open too long and we're losing focus. CI and IDEA are not related to Java migration - that's the scope. The feature is working, assuming this PR has gone through enough pipelines.
Since it works, there's no need for further trial and error on unrelated issues. If needed, we can open a separate issue, but this one is complete.
Please move forward with finishing this instead of exploring new checks.
a357b7b to
48c6bcb
Compare
|
Please resolve conflict |
48c6bcb to
35fbb45
Compare
rebase, thanks for being constructive. |
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now
Issue #17487: Add
Rewrite:UpgradeToJava17