Skip to content

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Sep 2, 2025

Issue #17487: Add Rewrite:UpgradeToJava17

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 67e64f3 to 6fa6630 Compare September 2, 2025 08:02
@Pankraz76 Pankraz76 marked this pull request as ready for review September 2, 2025 08:02
@Pankraz76 Pankraz76 mentioned this pull request Sep 3, 2025
@Pankraz76

This comment was marked as duplicate.

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 6fa6630 to 5f6033d Compare September 3, 2025 10:03
@Pankraz76
Copy link
Author

current checkstyle config goes again java convention:

Disallowed import - jakarta.annotation.Nullable. [ImportControlMain]

why so? this needs to be solved first.

@Pankraz76

This comment was marked as spam.

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch 4 times, most recently from 458f2f1 to f85ba24 Compare September 7, 2025 19:01
@romani
Copy link
Member

romani commented Sep 7, 2025

@Pankraz76 , FYI, we merged most initial rewrite config, please rebase

@Pankraz76
Copy link
Author

thank you so much.

Teamwork makes the dream work.

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch 2 times, most recently from 4703948 to 595cd41 Compare September 7, 2025 21:47
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch 2 times, most recently from 6d3d1ab to 8ab0cef Compare September 8, 2025 19:54
@Pankraz76 Pankraz76 requested a review from timtebeek September 8, 2025 19:55
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 8ab0cef to b7e208c Compare September 9, 2025 10:45
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 105d62b to f9fcab5 Compare September 12, 2025 09:35
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 649fe5a to 34eea75 Compare September 12, 2025 10:01
@Pankraz76 Pankraz76 requested a review from romani September 12, 2025 10:02
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 34eea75 to 0a1be48 Compare September 12, 2025 11:50
@romani
Copy link
Member

romani commented Sep 12, 2025

Please use in commit reference to some issue that is related to openrewire updates

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch 2 times, most recently from 69efb5f to b4534aa Compare September 12, 2025 19:12
@Pankraz76 Pankraz76 changed the title Issue #17487: Introduce Rewrite:UpgradeToJava17 Issue #17487: Add Rewrite:UpgradeToJava17 Sep 12, 2025
@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from b4534aa to f8a73d4 Compare September 12, 2025 20:03
@romani
Copy link
Member

romani commented Sep 12, 2025

Conflict

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from f8a73d4 to c0bf782 Compare September 13, 2025 10:35
@Pankraz76
Copy link
Author

rebase

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last:

* @param value the value to get the int stream from.
* @return the int stream.
* @noinspectionreason ChainOfInstanceofChecks - We will deal with this at
* <a href="https://github.com/checkstyle/checkstyle/issues/13500">13500</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit weird, as IDEA use @noinspection tag, and you do not use it.
@noinspectionreason is checkstyle specific javadoc tag to keep context why suppression happened.

this means that IDEA inspection might not complain on this code any more, can you try to remove it ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduced to @noinspection ChainOfInstanceofChecks like other usage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes need it to make CI happy.

just c&p and we good to go.

good teamwork, thanks.

[ERROR] [checkstyle] [ERROR] /home/circleci/project/src/main/java/com/puppycrawl/tools/checkstyle/site/SiteUtil.java:1103:7: @noinspection Javadoc tags should be accompanied by a @noinspectionreason tag, explaining why we suppressed inspection. [MatchXpath]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both should be used.
But try without all first, looks like idea inspection are complaining in this any more

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short: No. Its working and we are off topic losing focus on random experiments checking CI or idea both outside of tickets scope.

Merge or i will close, have invested enough on this already.

Long:
Both are already in use as required. We have failed multiple times having every variant, which is very annoying and makes me want to reject this.
I don't see the need to investigate why it works now or why it doesn't in other cases. These details aren't relevant.

We haven't eliminated all variants yet, and asking for more iterations is wasting time:

  • none
  • one
  • just the reason
  • just the marker

There's no value in repeating these redundancies expecting different results from the current state.

Let's consider experiments later. This feature has been open too long and we're losing focus. CI and IDEA are not related to Java migration - that's the scope. The feature is working, assuming this PR has gone through enough pipelines.

Since it works, there's no need for further trial and error on unrelated issues. If needed, we can open a separate issue, but this one is complete.

Please move forward with finishing this instead of exploring new checks.

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch 3 times, most recently from a357b7b to 48c6bcb Compare September 13, 2025 14:53
@Pankraz76 Pankraz76 requested a review from romani September 13, 2025 14:54
@romani
Copy link
Member

romani commented Sep 13, 2025

Please resolve conflict

@Pankraz76 Pankraz76 force-pushed the openrewrite-into-UpgradeToJava17 branch from 48c6bcb to 35fbb45 Compare September 14, 2025 10:10
@Pankraz76
Copy link
Author

Please resolve conflict

rebase, thanks for being constructive.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants