Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/79454cc_2025101345/reports/diff/index.html

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a4eaf13_2025072930/reports/diff/index.html

@romani we cover these names. I tested them locally. I forgot to include the Suppression in the regression config.

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a4eaf13_2025122759/reports/diff/index.html

such methods does not have @Test so that is why it stays as violation https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/a4eaf13_2025122759/reports/diff/guava/index.html#A3

am I right?
strange that kind of same in our Inputs are ok.

such methods does not have @test so that is why it stays as violation

Normal methods & Test methods, both follows lowerCamelCase so both of them follows same naming conventions.

https://google.github.io/styleguide/javaguide.html#s5.2.3-method-names

The current regex we're using doesn't allow for camel casing characters and digits together, for example testTest99_99, test_Test, testTest_Test, etc. Please adjust the regex according to this @mohitsatr

@Zopsss @romani

Underscores may appear in JUnit test method names to separate logical components of the name

Underscores are only allowed in test method. we can't put them in normal Method names. Normal methods & Test methods, both use same regex format. so we allow the following formats, we are also making underscores valid for normal functions.

testTest99_99
test_Test
testTest_Test

Underscores are only allowed in test method. we can't put them in normal Method names. Normal methods & Test methods, both use same regex format. so we allow the following formats, we are also making underscores valid for normal functions.

From style guide: https://google.github.io/styleguide/javaguide.html#s5.2.3-method-names

Method names are written in lowerCamelCase.
....
Underscores may appear in JUnit test method names to separate logical components of the name, with each component written in lowerCamelCase, for example transferMoney_deductsFromSource. There is no One Correct Way to name test methods.

from lowerCamelCase rule:

In very rare circumstances (for example, multipart version numbers), you may need to use underscores to separate adjacent numbers, since numbers do not have upper and lower case variants.

In the style guide it is mentioned that method names should be in lower camel case ( which allows for underscores ) and it is also separately mentioned that JUnit test methods can also use underscores.

So it is a bit confusing, if normal methods are allowed to have underscores or not. It is mentioned that Method names are written in lowerCamelCase which allows for underscores, so I think we should also allow for it? @romani @mohitsatr please share your opinion.

@Zopsss

In very rare circumstances (for example, multipart version numbers),

Let's not think of Multipart version number methods as normal methods. #17708 (comment)

Style guide has mentioned that normal methods can use lowerCamelCase, which means it can have underscores. @romani please correct me if I'm wrong.

Unfortunately Google style is not exact.
From one side they say that _ can be used in test methods to combine sentences. From another side in general camel case explanation, _ is allowed for numbers in all names(except package and generic names).

So if we can not write Regexp that decently covers allowance of _ before digits. We need to allow _ and update coverage table that false negatives to catch illegal underscore will be done when we finish new Check creation, might be not this year.

For methods: allow underscore Only between sentences for tests and for all methods between digits.
Underscore is valid separator of digits in all names, even in class names

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ed677a5_2025133041/reports/diff/index.html

�[1;31mERROR�[m] COMPILATION ERROR : 
[�[1;34mINFO�[m] -------------------------------------------------------------
[�[1;31mERROR�[m] /home/circleci/project/src/it/resources/com/google/checkstyle/test/
chapter5naming/rule53camelcase/
InputUnderscoreUsedInNames.java:[8,24] 
variable guava33_4_6 not initialized in the default constructor

We need to restore default values.
Or better remove "final" from all of them

Github, generate report

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ec7e6df_2025070954/reports/diff/index.html

class CoverterToKotlinVersion1_9_24 {} // violation, false-positive, 'must match pattern'

was removed. as it was addressed in #17835

basic implementation is merged
all false negatves will be addressed in next issue