Skip to content

Issue #17487: Introduce Rewrite covering S1144: Unused "private" methods should be removed #17545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pankraz76 wants to merge 1 commit into from
Closed

Issue #17487: Introduce Rewrite covering S1144: Unused "private" methods should be removed #17545

Pankraz76 wants to merge 1 commit into from

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Aug 4, 2025 •
edited
Loading

This was referenced Aug 4, 2025
Closed
Closed
@Pankraz76 Pankraz76 marked this pull request as ready for review August 4, 2025 13:29
@Pankraz76

This comment was marked as resolved.

Sign in to view
@Pankraz76 Pankraz76 force-pushed the openrewrite-into branch 6 times, most recently from 4b9ed7a to df73a23 Compare August 5, 2025 07:09
@Pankraz76
Copy link
Author

Pankraz76 commented Aug 5, 2025

Kindly consider this first, then the follow ups will be very simple to oversee. @romani

@Pankraz76

This comment was marked as resolved.

Sign in to view
@Pankraz76 Pankraz76 mentioned this pull request Aug 5, 2025
Merged
@Pankraz76 Pankraz76 mentioned this pull request Aug 5, 2025
Closed
3 tasks
@Pankraz76 Pankraz76 force-pushed the openrewrite-into branch 2 times, most recently from 797c0f0 to 5ace47b Compare August 5, 2025 13:31
romani
romani requested changes Aug 5, 2025
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@Pankraz76 Pankraz76 force-pushed the openrewrite-into branch 4 times, most recently from 6e59d50 to 50b16c0 Compare August 5, 2025 16:17
@Pankraz76 Pankraz76 requested a review from romani August 5, 2025 16:18
@Pankraz76

This comment was marked as resolved.

Sign in to view
@Pankraz76 Pankraz76 force-pushed the openrewrite-into branch 2 times, most recently from fc0c923 to 21262a6 Compare August 5, 2025 17:31
@Pankraz76
Copy link
Author

Pankraz76 commented Aug 5, 2025 •
edited
Loading

will me much faster.

considering dedicated test run on CI comparing both, its seems to be quite a similar result as expected, due to the same workload.

./.ci/validation.sh rewriteRun git-diff
33m 39s

./.ci/validation.sh rewriteDryRun
33m 15s

This makes the extra configuration questionable.

Its "just" cosmetics, how you want to handle it is up to you.

dryrun will provide functional output how to fix.

Might want to go stay (c)lean, considering convent over config (principle).

@Pankraz76 Pankraz76 mentioned this pull request Sep 3, 2025
Merged
@Pankraz76 Pankraz76 force-pushed the openrewrite-into branch 4 times, most recently from a7a8c0b to 3758be0 Compare September 3, 2025 10:09
@Pankraz76 Pankraz76 mentioned this pull request Sep 3, 2025
Closed
9 tasks
@Pankraz76 Pankraz76 mentioned this pull request Sep 3, 2025
Merged
9 tasks
@Pankraz76 Pankraz76 force-pushed the openrewrite-into branch 8 times, most recently from 13162fc to 06f9cea Compare September 3, 2025 18:54
@Pankraz76
Copy link
Author

Pankraz76 commented Sep 4, 2025

happy ci, ready to merge and fix the code of check sustainable.

@Pankraz76 Pankraz76 mentioned this pull request Sep 4, 2025
Closed
@Pankraz76 Pankraz76 mentioned this pull request Sep 4, 2025
Closed
@Pankraz76
Copy link
Author

Pankraz76 commented Sep 4, 2025

stable over all tested now several times.

Ready for final feedback @romani

Thanks for achievement

Pankraz76
Pankraz76 commented Sep 7, 2025
View reviewed changes
rewrite.yml
- code-quality
recipeList:
- org.checkstyle.autofix.CheckstyleAutoFix:
violationReportPath: "target/cs_errors.xml"
Copy link
Author

@Pankraz76 Pankraz76 Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working locally:

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12.343 s
[INFO] Finished at: 2025-09-07T23:18:35+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.openrewrite.maven:rewrite-maven-plugin:6.17.0:run (default-cli) on project checkstyle: Execution default-cli of goal org.openrewrite.maven:rewrite-maven-plugin:6.17.0:run failed: Failed to parse checkstyle XML report from: target/cs_errors.xml: target/cs_errors.xml (No such file or directory) -> [Help 1]                                                                                                                              
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.openrewrite.maven:rewrite-maven-plugin:6.17.0:run (default-cli) on project checkstyle: Execution default-cli of goal org.openrewrite.maven:rewrite-maven-plugin:6.17.0:run failed: Failed to parse checkstyle XML report from: target/cs_errors.xml                                                                                                                                            
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal org.openrewrite.maven:rewrite-maven-plugin:6.17.0:run failed: Failed to parse checkstyle XML report from: target/cs_errors.xml
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
Caused by: java.lang.IllegalArgumentException: Failed to parse checkstyle XML report from: target/cs_errors.xml
    at org.checkstyle.autofix.parser.CheckstyleReportParser.parse (CheckstyleReportParser.java:97)
    at org.checkstyle.autofix.CheckstyleAutoFix.getRecipeList (CheckstyleAutoFix.java:86)
    at org.openrewrite.Recipe.validate (Recipe.java:473)
    at org.openrewrite.Recipe.validate (Recipe.java:447)
    at org.openrewrite.Recipe.validate (Recipe.java:450)
    at org.openrewrite.Recipe.validateAll (Recipe.java:484)
    at org.openrewrite.maven.AbstractRewriteBaseRunMojo.listResults (AbstractRewriteBaseRunMojo.java:139)
    at org.openrewrite.maven.AbstractRewriteRunMojo.execute (AbstractRewriteRunMojo.java:66)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
Caused by: java.io.FileNotFoundException: target/cs_errors.xml (No such file or directory)
    at java.io.FileInputStream.open0 (Native Method)
    at java.io.FileInputStream.open (FileInputStream.java:213)
    at java.io.FileInputStream.<init> (FileInputStream.java:152)
    at org.checkstyle.autofix.parser.CheckstyleReportParser.parse (CheckstyleReportParser.java:65)
    at org.checkstyle.autofix.CheckstyleAutoFix.getRecipeList (CheckstyleAutoFix.java:86)
    at org.openrewrite.Recipe.validate (Recipe.java:473)
    at org.openrewrite.Recipe.validate (Recipe.java:447)
    at org.openrewrite.Recipe.validate (Recipe.java:450)
    at org.openrewrite.Recipe.validateAll (Recipe.java:484)
    at org.openrewrite.maven.AbstractRewriteBaseRunMojo.listResults (AbstractRewriteBaseRunMojo.java:139)
    at org.openrewrite.maven.AbstractRewriteRunMojo.execute (AbstractRewriteRunMojo.java:66)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke (Method.java:580)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
➜  checkstyle git:(master) ✗ git reset --soft $(git merge-base master HEAD)                                                               

➜  checkstyle git:(openrewrite-into) ✗

Copy link
Author

@Pankraz76 Pankraz76 Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but ment to run on cloud wich is really nice. Now check has most advances CI somehow. Congrats.

@Pankraz76
Copy link
Author

Pankraz76 commented Sep 8, 2025

reworked into sanity-check featuring org.checkstyle.CheckstyleAutoFix:

@Pankraz76 Pankraz76 closed this Sep 8, 2025
This was referenced Sep 24, 2025
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani Awaiting requested review from romani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @romani