Skip to content

Issue #17047: Migrate JUnit asserts to AssertJ#17048

Closed
Pankraz76 wants to merge 1 commit intocheckstyle:masterfrom
Pankraz76:JUnitToAssertj
Closed

Issue #17047: Migrate JUnit asserts to AssertJ#17048
Pankraz76 wants to merge 1 commit intocheckstyle:masterfrom
Pankraz76:JUnitToAssertj

Conversation

@Pankraz76
Copy link
Copy Markdown

@Pankraz76 Pankraz76 commented May 9, 2025

Issue #17047: Migrate JUnit asserts to AssertJ

item:

ertyCacheFileTest.java:514:22: Name 'i' must match pattern '^(id)|([a-z][a

@Pankraz76
Copy link
Copy Markdown
Author

bug:

Cannot resolve method 'assertThatExceptionOfType' in 'CommonUtilTest'

image

@Pankraz76
Copy link
Copy Markdown
Author

Cannot resolve method 'assertThatExceptionOfType' in 'JavadocMetadataScraperTest'

@Pankraz76
Copy link
Copy Markdown
Author

api/AbstractCheckTest.java:[282,19] getAcceptableTokens() in <anonymous com.puppycrawl.tools.checkstyle.api.AbstractCheckTest$9> cannot override getAcceptableTokens() in com.puppycrawl.tools.checkstyle.api.AbstractCheck

@Pankraz76
Copy link
Copy Markdown
Author

AbstractCheckTest.java:[282,19] getAcceptableTokens() in <anonymous com.puppycrawl.tools.checkstyle.api.AbstractCheckTest$9> cannot override getAcceptableTokens() in com.puppycrawl.tools.checkstyle.api.AbstractCheck

@Pankraz76 Pankraz76 force-pushed the JUnitToAssertj branch 2 times, most recently from 21eaa83 to e7d394e Compare May 9, 2025 18:24
@Pankraz76
Copy link
Copy Markdown
Author

Pankraz76 commented May 9, 2025

checkers issues: LocalVariableName

no change still failing:

image

@Pankraz76
Copy link
Copy Markdown
Author

undo failing:

still fail if untouched:

MainTest.java:51:18: Name 'i' must match pattern '^(id)|([a-z][a-z0-9][a-zA-Z0-9]+)$'. [LocalVariableName]

@Pankraz76
Copy link
Copy Markdown
Author

its only changing names and scope this could be done but rest not important. But discovery might be worth it.

@Pankraz76 Pankraz76 closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant