Issue #16641: FileContents.getJavadocBefore should skip block comment… #16646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahfouz72
force-pushed
the
issue-16641
branch
2 times, most recently
from
73ffb6b to
4fda117
Compare
|
Github, generate report |
|
Github, generate report for JavadocChecks |
|
Report is good. |
|
@rnveach please review |
rnveach
reviewed
Mar 26, 2025
rnveach
reviewed
Mar 26, 2025
...tools/checkstyle/checks/javadoc/missingjavadoctype/InputMissingJavadocTypeAboveComments.java
Outdated
Show resolved
Hide resolved
rnveach
approved these changes
Mar 27, 2025
…ck comments only if it is alone in line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16641
Diff Regression config: https://raw.githubusercontent.com/mahfouz72/test-configs/refs/heads/javadoc-checks/JavadocChecks/config.xml