Issue #14019 kill mutation for ScopeUtil #16546
Conversation
Abdelrhmansersawy
force-pushed
the
killMutation
branch
4 times, most recently
from
b9fbdac to
f4d37cb
Compare
| } | ||
| else if (token.getType() == TokenTypes.LITERAL_NEW | ||
| token != null; token = token.getParent()) { | ||
| if (TokenUtil.isOfType(token, TokenTypes.LITERAL_NEW, tokenType) |
There was a problem hiding this comment.
You changed until method .
Please put wording in description of PR on why is it safe to do code changes.
Please identify all affected Checks by this update, what modules use this function.
We need to run diff regression report.
There was a problem hiding this comment.
Please share list of modules and I will instruct on further steps.
There was a problem hiding this comment.
Affected Modules:
The isInBlockOf() method is used in the following places:
- ScopeUtil.java
- CyclomaticComplexityCheck.java
Could you please confirm if I understood your question correctly, or let me know if there's anything else I should check?
There was a problem hiding this comment.
It would help me if you share screenshot from IDE on "hierarchy of calls" with expanded nodes up to XxxxCheck
There was a problem hiding this comment.
@romani
The approach I used is based on a previous commit in this PR.
Previously, the code used this pattern:
if (type == TokenTypes.METHOD_DEF
|| type == TokenTypes.CTOR_DEF
|| type == TokenTypes.INSTANCE_INIT
|| type == TokenTypes.STATIC_INIT
|| type == TokenTypes.LAMBDA) {In the current version, it has been updated to:
if (TokenUtil.isOfType(token, TokenTypes.METHOD_DEF,
TokenTypes.CTOR_DEF, TokenTypes.INSTANCE_INIT,
TokenTypes.STATIC_INIT, TokenTypes.LAMBDA)) {I believe using the TokenUtil.isOfType method is safer and aligns with the existing code style.
Additionally, a similar modification was made in another accepted commit:
69ebc814c00d6b6764c5462b546f3d2a214ec35d
Also, there is an closed issue that suggests converting such patterns to this style:
Issue #8048: Enforce usage of TokenUtil.isOfType method
There was a problem hiding this comment.
In hierarchy of calls please expand all to let see whole tree
There was a problem hiding this comment.
I expanded nodes up to XxxxCheck, is it enough or you need more?
There was a problem hiding this comment.
Please take from that tree all modules/Checks. We need to do diff testing on them individually.
Please share textual list of Checks.
|
@romani |
This is just a list of packages of modules. |
|
@romani |
|
Report generation failed on phase "make_report", |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
Report generation failed on phase "make_report", |
|
Github, generate report |
|
As you see there are bunch of changes. |
Abdelrhmansersawy
force-pushed
the
killMutation
branch
from
f4d37cb to
ce54426
Compare
Issue #14019
Diff Regression config: https://gist.githubusercontent.com/Abdelrhmansersawy/a260374764de47cf113461589afb63fb/raw/d85d2b2a5fff191ac8a6a4eda54f28e108aa5888/config.xml