Issue #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144)#16435
Closed
Pankraz76 wants to merge 1 commit intocheckstyle:masterfrom
Closed
Issue #16435: introduce UnusedLocalMethodCheck (RSPEC-S1144)#16435Pankraz76 wants to merge 1 commit intocheckstyle:masterfrom
UnusedLocalMethodCheck (RSPEC-S1144)#16435Pankraz76 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
Pankraz76
commented
Feb 27, 2025
Pankraz76
commented
Feb 27, 2025
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
from
4f6a252 to
f9b73bd
Compare
Pankraz76
changed the title
RSPEC-S1144: UnusedLocalMethodCheckRSPEC-S1144 Add UnusedLocalMethodCheck
Author
|
is this any good? |
romani
requested changes
Feb 28, 2025
Member
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
Direction is good, but CI should be green
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
2 times, most recently
from
b24a8a0 to
015b919
Compare
Pankraz76
changed the title
RSPEC-S1144 Add UnusedLocalMethodCheckUnusedLocalMethodCheck
Pankraz76
changed the title
UnusedLocalMethodCheckUnusedLocalMethodCheck
Pankraz76
commented
Feb 28, 2025
| unused.catch.parameter=Неиспользуемый параметр catch ''{0}'' должен быть безымянным. | ||
| unused.lambda.parameter=Неиспользуемый лямбда-параметр ''{0}'' должен быть безымянным. | ||
| unused.local.var=Неиспользуемая локальная переменная ''{0}''. | ||
| unused.local.method=Неиспользуемая локальная переменная ''{0}''. |
Author
There was a problem hiding this comment.
mostly its c&p as I could not even encode this locally.
Pankraz76
commented
Feb 28, 2025
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
2 times, most recently
from
09a718f to
2504d30
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
11 times, most recently
from
e01d8c5 to
024d8d0
Compare
Pankraz76
commented
Mar 2, 2025
Author
Pankraz76
left a comment
Pankraz76
left a comment
There was a problem hiding this comment.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:02 min
[INFO] Finished at: 2025-03-02T01:02:41+01:00
[INFO] ------------------------------------------------------------------------
➜ checkstyle git:(UnusedPrivateMethodCheck-pr)
| @@ -0,0 +1,20 @@ | |||
| [*] | |||
Author
There was a problem hiding this comment.
without this is was impossible for me to apply the rules as idk how to outfix them and align them with the IDE out of the box. Thanks
Member
There was a problem hiding this comment.
if you really want to have this file, you need to create new issue, explain all details on what is it for and what are benefits. this will let us to evaluate if we can have it in repo and it will not interfere with others.
We try to be IDE agnostic, as people use a lot of editors and very diffeerent version.
Author
There was a problem hiding this comment.
Yes, it's kind of agnostic as it supports all common editors out of the box.
It's a good thing to extract things into a separate PR, but I need to be able to work on the code without having to configure like crazy. I will delete it right before merging. There are still some issues left.
Pankraz76
commented
Mar 2, 2025
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
2 times, most recently
from
600f71f to
8828f6b
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
3 times, most recently
from
9ae74f1 to
58d8547
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
3 times, most recently
from
b9382f3 to
9e35bff
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
2 times, most recently
from
48649f9 to
266514c
Compare
Pankraz76
commented
Mar 21, 2025
| href="checks/coding/unusedcatchparametershouldbeunnamed.html"/> | ||
| <item name="UnusedLambdaParameterShouldBeUnnamed" | ||
| href="checks/coding/unusedlambdaparametershouldbeunnamed.html"/> | ||
| <item name="UnusedLocalMethod" href="checks/coding/unusedlocalmethod.html"/> |
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
from
266514c to
3c1b39d
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
from
6aa93a1 to
6d2452f
Compare
4 tasks
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
2 times, most recently
from
c50cd91 to
77b569d
Compare
Pankraz76
changed the title
UnusedLocalMethodCheckUnusedLocalMethodCheck (RSPEC-S1144)
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
from
77b569d to
442b9d2
Compare
Pankraz76
changed the title
UnusedLocalMethodCheck (RSPEC-S1144)UnusedLocalMethodCheck (RSPEC-S1144)
Pankraz76
pushed a commit
to Pankraz76/checkstyle
that referenced
this pull request
Apr 4, 2025
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
from
442b9d2 to
aa01fe1
Compare
Pankraz76
force-pushed
the
UnusedPrivateMethodCheck-pr
branch
from
aa01fe1 to
5010eae
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #16435: introduce
UnusedLocalMethodCheck(RSPEC-S1144)