Issue #12817: fix switch-expression Indentation when appears on the start of the … #16418

mohitsatr · 2025-02-25T03:36:12Z

New module config: https://gist.githubusercontent.com/mohitsatr/937e10572dd412961b61c77577619dff/raw/7a47240f8793e7335adbd81c2806b375f0394815/google_checks_indentation.xml
Diff Regression projects: https://gist.githubusercontent.com/mohitsatr/68b0817ac52ff7773d35585ee12fc1cc/raw/9ba8e4fb324e1daf589874c6992f2aa87b03079a/list-of-projects.properties

mohitsatr · 2025-02-25T03:38:13Z

Github, generate report for indentation/all-examples-in-one

github-actions · 2025-02-25T04:04:22Z

Failed to download or process the specified configuration(s).
Error details:

Please ensure you've used one of the following commands correctly:

'GitHub, generate report for <config_bundle_path>'
'GitHub, generate report by config from <file_path>'
'GitHub, generate report for configs in PR description'

And check that all specified configs or files exist and are valid.

Link: https://github.com/checkstyle/checkstyle/actions/runs/13513122147

mohitsatr · 2025-02-25T05:13:17Z

Github, generate report

github-actions · 2025-02-25T06:05:36Z

Indentation/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/49517b4_2025060506/reports/diff/index.html

romani · 2025-03-02T14:46:02Z

I like fact that no changes except for one project.

camunda ( ±1196, -479, +717 )

this very scary difference.
lets handle it a bit differently. please try to guess what indentation is used in this project and make config that suites it, so we will use single config diff report run, so we should have less violations.
But main point will be even violation become different, or stay, we will see if it is correct or not.

mohitsatr · 2025-03-03T03:14:23Z

I tested examples locally with same config and it passes without any problem.

mohitsatr · 2025-03-03T03:49:14Z

Github, generate report for Indentation/Example1

github-actions · 2025-03-03T04:32:22Z

Report for Indentation/Example1:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/49517b4de8f560207093e3ba80a81d6ee33cc83c_2025043206/reports/diff/index.html

mohitsatr · 2025-03-03T04:42:35Z

Github, generate report

github-actions · 2025-03-03T05:40:19Z

Report generation failed on phase "make_report",
step .
Link: https://github.com/checkstyle/checkstyle/actions/runs/13623565702

mohitsatr · 2025-03-04T02:46:16Z

Github, generate report

github-actions · 2025-03-04T04:05:45Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/49517b4_2025040509/reports/diff/index.html

mohitsatr · 2025-03-04T04:09:50Z

@romani report is ready.

romani

Last minor:

src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheckTest.java

romani

Itet

...awl/tools/checkstyle/checks/indentation/indentation/InputIndentationSwitchOnStartOfLine.java

romani · 2025-03-08T22:01:14Z

Just curious, how much violations are on camunda , if just run Indentation validation of config that you have in PR description.
I think we can use New module config: {{URI to new_module_config.xml}} to get this. But we need list of projects to be only camunda.

mohitsatr · 2025-03-10T02:45:27Z

I'm having some difficulties specifying violations in google test suit.

every other test-case function has not specified any expected violation in them, so i was just following them.
could it be due to the asteriks(*) in the input file ?
I couldn't use full violation messages here, it violates 100 line length rule.

Zopsss · 2025-03-11T03:05:23Z

Can you try to debug to see what are the unexpected violations? If they're about line length limit then try to trim violation messages to:

// violation 'case' child * level 12, expected * 10

mohitsatr · 2025-03-11T04:08:54Z

@Zopsss I figured it out. regexp was not catching it because ("") were missing.
// violation "'case' child * level 8, expected * 10"

But now

as you can see, full message causes line-length issue, but it is not accepting shortened message either.

Zopsss · 2025-03-11T16:48:19Z

Add . at the end of your message and please always push changes to let us see the whole code

mohitsatr · 2025-03-12T03:35:44Z

@Zopsss . at the end does not help either. please check the code

mohitsatr · 2025-03-12T03:52:41Z

okay figured it out.

mohitsatr · 2025-03-12T04:20:53Z

i feel like there should be a page on the website about how to specify violations in input files, with different formats. we could also add how to write test functions. It'd make really easy for newcomers and time-saving as well. and we could avoid many repetitive questions . @romani what do you think, should i open an issue ?

mohitsatr · 2025-03-12T08:18:13Z

Just curious, how much violations are on camunda , if just run Indentation validation of config that you have in PR description. I think we can use New module config: {{URI to new_module_config.xml}} to get this. But we need list of projects to be only camunda.

let's try

mohitsatr · 2025-03-12T08:18:40Z

Github, generate report

github-actions · 2025-03-12T08:37:38Z

Report generation failed on phase "make_report",
step "Prepare environment".
Link: https://github.com/checkstyle/checkstyle/actions/runs/13806697335

mohitsatr · 2025-03-13T01:51:47Z

did I do something wrong in the configs/project file ?

mohitsatr · 2025-03-13T10:51:02Z

Github, generate report

github-actions · 2025-03-13T10:51:59Z

Report generation failed on phase "make_report",
step "Prepare environment".
Link: https://github.com/checkstyle/checkstyle/actions/runs/13832852114

mohitsatr · 2025-03-13T11:10:48Z

Github, generate report

github-actions · 2025-03-13T11:14:30Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4aaed8d_2025111411/reports/diff/index.html

romani · 2025-03-14T15:31:29Z

should i open an issue ?

Please create issue and feel free to send PR to resolve it, as look like know all pain points

mohitsatr · 2025-03-15T03:46:51Z

@romani is this #16418 (comment) what we wanted ?

romani

is this #16418 (comment) what we wanted ?

unfortunately too much violation to take use from it, but yes conceptually it is.
I just tried to find config that will produce minimal amount of violations, to let it reviewable by humans.

very good.

last request:

romani · 2025-03-15T14:45:27Z

...ogle/checkstyle/test/chapter4formatting/rule4841indentation/InputSwitchOnStartOfTheLine.java

+  String testMethod1(int i) {
+    String s =
+        switch (i) {
+          case 1 -> "one";


please make copy of correct to
...Correct.java files

see examples: https://github.com/checkstyle/checkstyle/tree/main/src/it/resources/com/google/checkstyle/test/chapter4formatting/rule4841indentation

in this case formatter will confirm that no violation from Checkstyle means no violation from java google formatter

the file is already in the right location in resources-noncompilable section. trying to put it in https://github.com/checkstyle/checkstyle/tree/main/src/it/resources/com/google/checkstyle/test/chapter4formatting/rule4841indentation trigger IDEA errors about switch expression not being compartiable with java11.

Keep same top folder noncopileable , but name file ..... Correct.java, to let CI run formatting on it.

…rt of the line

romani

thanks a lot for hard work on most complicated module in Checkstyle.

rdiachenko

lgtm

mohitsatr changed the title ~~Issue #12817: fix switch-expression when appears on the start of the …~~ Issue #12817: fix switch-expression Indentation when appears on the start of the … Feb 27, 2025

romani requested changes Mar 8, 2025

View reviewed changes

src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheckTest.java Outdated Show resolved Hide resolved

romani requested changes Mar 8, 2025

View reviewed changes

...awl/tools/checkstyle/checks/indentation/indentation/InputIndentationSwitchOnStartOfLine.java Show resolved Hide resolved

mohitsatr force-pushed the switch-newline-indentation branch from 49517b4 to 0748b8b Compare March 12, 2025 03:34

mohitsatr force-pushed the switch-newline-indentation branch from 0748b8b to 2ad2e4c Compare March 12, 2025 04:12

mohitsatr force-pushed the switch-newline-indentation branch from 2ad2e4c to 4aaed8d Compare March 12, 2025 08:17

romani requested changes Mar 15, 2025

View reviewed changes

Issue checkstyle#12817: fix switch-expression when appears on the sta…

eef0e7c

…rt of the line

mohitsatr force-pushed the switch-newline-indentation branch from 4aaed8d to eef0e7c Compare March 16, 2025 06:49

romani approved these changes Mar 20, 2025

View reviewed changes

romani requested a review from rdiachenko March 20, 2025 12:28

romani assigned rdiachenko Mar 20, 2025

rdiachenko approved these changes Mar 20, 2025

View reviewed changes

rdiachenko assigned romani and unassigned rdiachenko Mar 20, 2025

romani merged commit 600dc70 into checkstyle:master Mar 21, 2025
113 checks passed

mohitsatr deleted the switch-newline-indentation branch March 21, 2025 02:04

This was referenced Mar 24, 2025

False positives for google_checks when assigning variable to enhanced switch expression #15592

Closed

Issue #15769: fix false-positive indentation violations for block codes #16515

Open

romani mentioned this pull request Mar 27, 2025

Issue #15098: Indentation of switch block when no braces is now validated #16647

Closed

Issue #12817: fix switch-expression Indentation when appears on the start of the … #16418

Issue #12817: fix switch-expression Indentation when appears on the start of the … #16418

Conversation

mohitsatr commented Feb 25, 2025 • edited Loading

mohitsatr commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

mohitsatr commented Feb 25, 2025

github-actions bot commented Feb 25, 2025

romani commented Mar 2, 2025

mohitsatr commented Mar 3, 2025 • edited Loading

mohitsatr commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

mohitsatr commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

mohitsatr commented Mar 4, 2025

github-actions bot commented Mar 4, 2025

mohitsatr commented Mar 4, 2025

romani left a comment

Choose a reason for hiding this comment

romani left a comment

Choose a reason for hiding this comment

romani commented Mar 8, 2025 • edited Loading

mohitsatr commented Mar 10, 2025 • edited Loading

Zopsss commented Mar 11, 2025 • edited Loading

mohitsatr commented Mar 11, 2025 • edited Loading

Zopsss commented Mar 11, 2025

mohitsatr commented Mar 12, 2025

mohitsatr commented Mar 12, 2025

mohitsatr commented Mar 12, 2025 • edited Loading

mohitsatr commented Mar 12, 2025

mohitsatr commented Mar 12, 2025

github-actions bot commented Mar 12, 2025

mohitsatr commented Mar 13, 2025

mohitsatr commented Mar 13, 2025

github-actions bot commented Mar 13, 2025

mohitsatr commented Mar 13, 2025

github-actions bot commented Mar 13, 2025

romani commented Mar 14, 2025

mohitsatr commented Mar 15, 2025

romani left a comment • edited Loading

Choose a reason for hiding this comment

romani Mar 15, 2025

Choose a reason for hiding this comment

mohitsatr Mar 16, 2025 • edited Loading

Choose a reason for hiding this comment

romani Mar 16, 2025 • edited Loading

Choose a reason for hiding this comment

mohitsatr Mar 17, 2025

Choose a reason for hiding this comment

romani left a comment

Choose a reason for hiding this comment

rdiachenko left a comment

Choose a reason for hiding this comment

mohitsatr commented Feb 25, 2025 •

edited

Loading

mohitsatr commented Mar 3, 2025 •

edited

Loading

romani commented Mar 8, 2025 •

edited

Loading

mohitsatr commented Mar 10, 2025 •

edited

Loading

Zopsss commented Mar 11, 2025 •

edited

Loading

mohitsatr commented Mar 11, 2025 •

edited

Loading

mohitsatr commented Mar 12, 2025 •

edited

Loading

romani left a comment •

edited

Loading

mohitsatr Mar 16, 2025 •

edited

Loading

romani Mar 16, 2025 •

edited

Loading