Issue #15831: enabled allowEmptySwitchBlockStatements property of WhitespaceAround in google_checks.xml #15839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait build seems to be failing |
Zopsss
force-pushed
the
enable-empty-switch-statements
branch
from
8c78fe9 to
60ab7cf
Compare
…rty of WhitespaceAround in google_checks.xml
Zopsss
commented
Oct 31, 2024
Comment on lines
28
to
-55
| case Integer i when (i == 0) -> {} | ||
| // 2 violations above: | ||
| // ''{' is not followed by whitespace.' | ||
| // ''}' is not preceded with whitespace.' |
There was a problem hiding this comment.
Hmmm this bug was known but it didn't had an issue opened for it. Glad that we were able to solve it now.
There was a problem hiding this comment.
@Zopsss , testing base that you did at summer is awesome to prevent any problems.
We missed it as a lot of problems and we eliminated vast majority of them. But some still missed, it is ok. Main point that we unlikely to leak new regression.
|
build seems to be passing now :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15831
Enabled
allowEmptySwitchBlockStatements, added test cases and updatedInputFormattedXxxxxfile