Skip to content

Issue #13012: fix loading with non-ascii symbols in path#14883

Merged
nrmancuso merged 1 commit intocheckstyle:masterfrom
strkkk:13012_use_ascii
May 26, 2024
Merged

Issue #13012: fix loading with non-ascii symbols in path#14883
nrmancuso merged 1 commit intocheckstyle:masterfrom
strkkk:13012_use_ascii

Conversation

@strkkk
Copy link
Copy Markdown
Member

@strkkk strkkk commented May 18, 2024

Closes #13012

Attempt number 3 to fix this issue

@strkkk strkkk force-pushed the 13012_use_ascii branch 3 times, most recently from 1c70977 to bb020ec Compare May 18, 2024 13:58
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only point to improve

Comment thread src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java Outdated
@romani romani self-assigned this May 19, 2024
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Comment thread src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilTest.java Outdated
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

Comment thread src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtil.java
@strkkk strkkk force-pushed the 13012_use_ascii branch from bb020ec to 63d0fbb Compare May 20, 2024 15:24
Copy link
Copy Markdown
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested a review from nrmancuso May 21, 2024 15:23
@romani romani assigned nrmancuso and unassigned romani May 21, 2024
Copy link
Copy Markdown
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkstyle fails with "Path contains invalid character" if path to config file contains non-ascii characters

3 participants