Issue #13012: Use toASCIIString for all URIs#13016
Issue #13012: Use toASCIIString for all URIs#13016reftel wants to merge 1 commit intocheckstyle:masterfrom
Conversation
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
thanks a lot for fix.
Please add URI.toString to forbidden list of methods https://github.com/checkstyle/checkstyle/blob/master/config/signatures.txt (please share build out put failure to prove that it works), to avoid this problem in future completely.
We need green CI. Please follow CI failures.
items:
reftel
force-pushed
the
feature/to_ascii_string
branch
from
1cb2098 to
91cadd9
Compare
| try { | ||
| final String[] expected = CommonUtil.EMPTY_STRING_ARRAY; | ||
| verifyWithInlineConfigParser(configInDirWithNonAsciiCharacters.toString(), expected); | ||
| assertWithMessage("Test should fail if exception was not thrown").fail(); |
There was a problem hiding this comment.
We need test that show that validation works.
Can you put here full path after copy, it should be loaded.
Test should sounds easy: we cop file to folder with Unicode, we run validation, all works. ( Same as as your issue sounds)
|
circleci run-inspections fails because it thinks the Unicode escapes for æøå are unnecessary, but leaving them leads to a Checkstyle failure: So, the CI setup is at odds with the checkstyle configuration. |
|
And then there are more PITest failures, due to missing test cases for error message formatting. What started out as a obviously correct one-line fix has balooned into writing test cases for error message formatting and fixing broken CI setups. It is no longer worth the effort. We´ll just pin our version of maven-checkstyle-plugin to one that works instead. |
Very sad, overconstraint checking here. |
|
Yes delivery will quality is not easy. We will wait for someone who have more time to fix it. |
|
@romani Can I take this issue? I want to work on this after my current pending issue |
|
@AayushSaini101 , please be welcome take this issue. |
4 participants
Resolves Issue #13012.