-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileContents.getJavadocBefore()
: Comments should not be skipped if it is not alone in line
#16641
Comments
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 23, 2025
…ck comments only if it is alone in line
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 23, 2025
…ck comments only if it is alone in line
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 23, 2025
…ck comments only if it is alone in line
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 23, 2025
…ck comments only if it is alone in line
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 27, 2025
…ck comments only if it is alone in line
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 27, 2025
…ck comments only if it is alone in line
mahfouz72
added a commit
to mahfouz72/checkstyle
that referenced
this issue
Mar 28, 2025
…ck comments only if it is alone in line
pankratz76
pushed a commit
to pankratz76/checkstyle
that referenced
this issue
Mar 30, 2025
…ck comments only if it is alone in line
pankratz76
pushed a commit
to pankratz76/checkstyle
that referenced
this issue
Apr 1, 2025
…ck comments only if it is alone in line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#16546 (comment)
Detected at the report:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f4d37cb_2025053704/reports/diff/index.html
unfortunately, In my previous PR the config in the PR description was missing some important checks, so the report generated shows no difference but this was misleading.
After I checked a report in another PR (that was behind my commit on master). I saw the real diff due to my changes and analyzed the report all was good except for this case and the like
Example:
The issue because we skipped the line
/* package */ int x;
because it has a block comment. soint y
becomes associated with the Javadoc aboveint x
.The fix should be simple. A simple condition to see if the block comment is in a single line and not alone in the line
then we should not skip it.
The text was updated successfully, but these errors were encountered: