-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnnecessaryParenthesesCheck does not flag unnecessary parentheses in conditional expression #15263
Comments
Issue looks good to me. |
please add false negative label |
we usually place "bug" label after fix (as this label is for release notes) |
Is this still open and not assigned ? |
@MohanadKh03 , thanks a lot for help, you are always welcome to fix any issues. We highly recommend (but not a mandatory requirement) for new contributors to finish one issue in. Each group "good xxxx issue" in this case contributor learning gradually how our project works, and there less likely to be failure to finish fix. |
@romani |
Better to discuss in PR, see you in PR |
…ryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
… conditional expressions to UnnecessaryParenthesesCheck
…al expressions to UnnecessaryParenthesesCheck
detected at #15250 (comment)
I have read check documentation: https://checkstyle.org/checks/coding/unnecessaryparentheses.html#UnnecessaryParentheses
I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run
I have executed the cli and showed it below, as cli describes the problem better than 1,000 words
Describe what you expect in detail.
UnnecessaryParentheses
should flag unnecessary parentheses in conditional expressions. We should addQuestion
to the acceptable tokens or something.The text was updated successfully, but these errors were encountered: