-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Closed
Labels
Milestone
Description
In PR #14136 I added Error Prone Support to Checkstyle. As @romani suggested in #14129, I'd like to create this issue to discuss which checks from Error Prone Support are useful for the Checkstyle project to enable.
The full list of checks can be found here: https://error-prone.picnic.tech/.
- AmbiguousJsonCreator
- AssertJIsNull
- AutowiredConstructor
- CanonicalAnnotationSyntax
- CollectorMutability
- DirectReturn
- EmptyMethod
- ExplicitEnumOrdering
- FormatStringConcatenation
- IdentityConversion
- ImmutablesSortedSetComparator
- IsInstanceLambdaUsage
- JUnitClassModifiers
- JUnitMethodDeclaration
- JUnitValueSource
- LexicographicalAnnotationAttributeListing
- MockitoMockClassReference
- MockitoStubbing
- NestedOptionals
- PrimitiveComparison
- RedundantStringConversion
- Slf4jLogStatement
- StaticImport
- StringJoin
- TimeZoneUsage
I omitted some of the checks from the list as they are definitely not applicable to this project (for example they are Spring or Reactor focused).
Let me know if this is the right approach, or if we should change something.
I'm curious to hear your thoughts on the checks!