Skip to content

Enable checks from Error Prone Support #14137

@rickie

Description

@rickie

In PR #14136 I added Error Prone Support to Checkstyle. As @romani suggested in #14129, I'd like to create this issue to discuss which checks from Error Prone Support are useful for the Checkstyle project to enable.

The full list of checks can be found here: https://error-prone.picnic.tech/.

  1. AmbiguousJsonCreator
  2. AssertJIsNull
  3. AutowiredConstructor
  4. CanonicalAnnotationSyntax
  5. CollectorMutability
  6. DirectReturn
  7. EmptyMethod
  8. ExplicitEnumOrdering
  9. FormatStringConcatenation
  10. IdentityConversion
  11. ImmutablesSortedSetComparator
  12. IsInstanceLambdaUsage
  13. JUnitClassModifiers
  14. JUnitMethodDeclaration
  15. JUnitValueSource
  16. LexicographicalAnnotationAttributeListing
  17. MockitoMockClassReference
  18. MockitoStubbing
  19. NestedOptionals
  20. PrimitiveComparison
  21. RedundantStringConversion
  22. Slf4jLogStatement
  23. StaticImport
  24. StringJoin
  25. TimeZoneUsage

I omitted some of the checks from the list as they are definitely not applicable to this project (for example they are Spring or Reactor focused).

Let me know if this is the right approach, or if we should change something.

I'm curious to hear your thoughts on the checks!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions