Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Indentation errors for expression switches with google_checks.xml #12817

Closed
cushon opened this issue Mar 10, 2023 · 5 comments · Fixed by #16418
Closed

Incorrect Indentation errors for expression switches with google_checks.xml #12817

cushon opened this issue Mar 10, 2023 · 5 comments · Fixed by #16418
Labels
approved bug google style indentation
Milestone
10.22.0

Comments

@cushon
Copy link
Contributor

cushon commented Mar 10, 2023 

$ javac -fullversion
javac full version "20-ea+35-2342"
$ javac T.java

$ wget https://raw.githubusercontent.com/checkstyle/checkstyle/d02e867225c3eaa43dc681c2827ce89799dee88f/src/main/resources/google_checks.xml

$ cat T.java
class T {
  void doSomething(int i) {
    String s =
        switch (i) {
          case 1 -> "one";
          case 2 -> "two";
          default -> throw new AssertionError();
        };
  }
}
$ RUN_LOCALE="-Duser.language=en -Duser.country=US"
$ java -jar checkstyle-10.8.1-all.jar -c google_checks.xml T.java
Starting audit...
[WARN] /tmp/tmp.zK57404080/T.java:4:9: 'switch' has incorrect indentation level 8, expected level should be 4. [Indentation]
[WARN] /tmp/tmp.zK57404080/T.java:5:11: 'case' child has incorrect indentation level 10, expected level should be 6. [Indentation]
[WARN] /tmp/tmp.zK57404080/T.java:6:11: 'case' child has incorrect indentation level 10, expected level should be 6. [Indentation]
[WARN] /tmp/tmp.zK57404080/T.java:7:11: 'case' child has incorrect indentation level 10, expected level should be 6. [Indentation]
[WARN] /tmp/tmp.zK57404080/T.java:8:9: 'switch rcurly' has incorrect indentation level 8, expected level should be 4. [Indentation]
Audit done.

Describe what you expect in detail.

I expected no errors to be produced, because the input is formatted in a way that complies with the Google Java Style Guide
@cushon cushon mentioned this issue Mar 10, 2023
Closed
@rajeshkanugu
Copy link

maybe you are having problem with the compiler i have executed the file and it got implemented corrected.May be you are using the early release version.The file runs correctly with Java(TM) SE Runtime Environment (build 19.0.2+7-44)
Java HotSpot(TM) 64-Bit Server VM (build 19.0.2+7-44, mixed mode, sharing).

@rajeshkanugu
Copy link

`class T {
void doSomething(int i) {
String s =
switch (i) {
case 1 -> "one";
case 2 -> "two";
default -> throw new AssertionError();
};
}

public static void main(String[] args) {
    T t = new T();
    t.doSomething(1); // calling the doSomething method with the argument 1
}

}
`

@destebanm
Copy link

Hi!
I have the same issue with switch.

I reported in google/google-java-format#915

Thanks!

@deepanshu150895
Copy link

deepanshu150895 commented Jun 6, 2023 •
edited
Loading

I am also facing this issue,
error - 'switch' has incorrect indentation level 8, expected level should be 4. [Indentation]
I tried with openjdk 17.0.6

static void testMethod(int month) {
    int result =
        switch (month) {
          case JANUARY, JUNE, JULY -> 3;
          case FEBRUARY, SEPTEMBER, OCTOBER, NOVEMBER, DECEMBER -> 1;
          case MARCH, MAY, APRIL, AUGUST -> {
            yield month * 4;
          }
          default -> 0;
        };
  }

mohitsatr added a commit to mohitsatr/checkstyle that referenced this issue Feb 25, 2025
@mohitsatr
Issue checkstyle#12817: fix switch-expression when appears on the sta…
49517b4 
…rt of the line
@mohitsatr mohitsatr mentioned this issue Feb 25, 2025
Merged
mohitsatr added a commit to mohitsatr/checkstyle that referenced this issue Mar 12, 2025
@mohitsatr
Issue checkstyle#12817: fix switch-expression when appears on the sta…
537b4ff 
…rt of the line
mohitsatr added a commit to mohitsatr/checkstyle that referenced this issue Mar 12, 2025
@mohitsatr
Issue checkstyle#12817: fix switch-expression when appears on the sta…
2ad2e4c 
…rt of the line
mohitsatr added a commit to mohitsatr/checkstyle that referenced this issue Mar 12, 2025
@mohitsatr
Issue checkstyle#12817: fix switch-expression when appears on the sta…
4aaed8d 
…rt of the line
mohitsatr added a commit to mohitsatr/checkstyle that referenced this issue Mar 16, 2025
@mohitsatr
Issue checkstyle#12817: fix switch-expression when appears on the sta…
eef0e7c 
…rt of the line
romani pushed a commit that referenced this issue Mar 21, 2025
@mohitsatr @romani
Issue #12817: fix switch-expression when appears on the start of the …
600dc70 
…line
@romani romani added the bug label Mar 21, 2025
@github-actions github-actions bot added this to the 10.22.0 milestone Mar 21, 2025
@romani
Copy link
Member

romani commented Mar 21, 2025

Fix is merged

mohitsatr added a commit to mohitsatr/checkstyle that referenced this issue Mar 21, 2025
@mohitsatr
Issue checkstyle#12817: fix switch-expression when appears on the sta…
e1764a4 
…rt of the line
@romani romani mentioned this issue Mar 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved bug google style indentation
Projects
Polishing Google Style implementation
Status: Done
Milestone
10.22.0
6 participants
@cushon @romani @rnveach @destebanm @deepanshu150895 @rajeshkanugu