UnusedLocalVariable: False Positive when inner class has same field as variable #11374

Vyom-Yadav · 2022-03-07T09:22:39Z

I have read check documentation: https://checkstyle.sourceforge.io/config_coding.html#UnusedLocalVariable
I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run
I have executed the cli and showed it below, as cli describes the problem better than 1,000 words

/var/tmp $ javac Test.java

/var/tmp $ cat config.xml

<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
        "https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="Checker">
    <module name="TreeWalker">
        <module name="UnusedLocalVariable"/>
    </module>
</module>

/var/tmp $ cat Test.java

public class Test {

    static class m {
        static class h {
            public int a = 12;
        }
    }

    static class j {
        static void method() {
            int a = 1000; // unexpected violation
            m.h obj = new m.h() { // object of Test.j.m.h and not of Test.m.h
                @Override
                void method() {
                    System.out.println("a = " + a); // local var a
                }
            };
            obj.method();
        }

        static class m {
            static class h {
                void method() {
                }
            }
        }
    }

    public static void main(String[] args) {
        j.method();
    }
}

/var/tmp $ RUN_LOCALE="-Duser.language=en -Duser.country=US"
/var/tmp $ java $RUN_LOCALE -jar checkstyle-10.0-all.jar -c config.xml Test.java
Starting audit...
[ERROR] /var/tmp/Test.java:11:13: Unused local variable 'a'. [UnusedLocalVariable]
Audit done.
Checkstyle ends with 1 errors.

/var/tmp $ java Test.java
a = 1000

Describe what you expect in detail.

/var/tmp $ RUN_LOCALE="-Duser.language=en -Duser.country=US"
/var/tmp $ java $RUN_LOCALE -jar checkstyle-10.0-all.jar -c config.xml Test.java
Starting audit...
Audit done.

Discovered while working on #11365, the source has been identified, the fix has been done locally, will be pushed soon.

The text was updated successfully, but these errors were encountered:

Vyom-Yadav · 2022-03-22T04:01:43Z

@Vishakhakumawat Fix has already been done, just pushing to remote is remaining, it is mentioned in issue description

…ses in UnusedLocalVariableCheck

…sedLocalVariableCheck

nrmancuso · 2024-12-16T13:25:26Z

Closed via #15969

### What changes were proposed in this pull request? This PR aims to upgrade `checkstyle` from 10.20.2 to 10.21.2. ### Why are the changes needed? To pick up bug fixes: - checkstyle-10.21.2 checkstyle/checkstyle#15939 - lineWrappingIndentation falsely detects incorrect indentation for text blocks checkstyle/checkstyle#16101 - ignoreFieldDeclaration property should have the highest priority in MagicNumberCheck - checkstyle-10.21.1 checkstyle/checkstyle#11374 - UnusedLocalVariable: False Positive when inner class has same field as variable Full release notes: - https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.21.2 - https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.21.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually by: ``` bash ./dev/lint-java ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49899 from wayneguow/checkstyle. Authored-by: Wei Guo <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

### What changes were proposed in this pull request? This PR aims to upgrade `checkstyle` from 10.20.2 to 10.21.2. ### Why are the changes needed? To pick up bug fixes: - checkstyle-10.21.2 checkstyle/checkstyle#15939 - lineWrappingIndentation falsely detects incorrect indentation for text blocks checkstyle/checkstyle#16101 - ignoreFieldDeclaration property should have the highest priority in MagicNumberCheck - checkstyle-10.21.1 checkstyle/checkstyle#11374 - UnusedLocalVariable: False Positive when inner class has same field as variable Full release notes: - https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.21.2 - https://github.com/checkstyle/checkstyle/releases/tag/checkstyle-10.21.1 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually by: ``` bash ./dev/lint-java ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49899 from wayneguow/checkstyle. Authored-by: Wei Guo <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

Vyom-Yadav mentioned this issue Mar 7, 2022

Issue #11201: Moved methods common in UnusedLocalVariableCheck and FinalClassCheck to util #11369

Merged

nrmancuso added the approved label Mar 10, 2022

checkstyle deleted a comment from Vyom-Yadav Mar 11, 2022

checkstyle deleted a comment from nrmancuso Mar 11, 2022

checkstyle deleted a comment from Vyom-Yadav Mar 11, 2022

checkstyle deleted a comment from Vishakhakumawat Mar 22, 2022

checkstyle deleted a comment from Vyom-Yadav Mar 22, 2022

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

a720b1c

Vyom-Yadav mentioned this issue Mar 26, 2022

Fixed false positives related to anonymous inner classes in UnusedLocalVariable and FinalClass #11466

Closed

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

4d4571d

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

d4e5568

This was referenced Mar 26, 2022

Fixed false positives related to anonymous inner classes in UnusedLocalVariable and FinalClass #11467

Closed

Issue #11365: Fixed false positives related to anonymous inner classes in FinalClassCheck #11468

Merged

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

7143acd

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

e3bb181

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

dd44ebb

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

4249aea

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

ccc5799

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

5d9950a

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 1, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

eaff1d5

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 3, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

e6b0cfc

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 3, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

e803e40

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 3, 2022

Issue checkstyle#11374: Fix false positive in UnusedLocalVariableCheck

f92375d

nburles mentioned this issue Jul 19, 2022

False Positive: UnusedLocalVariableCheck #11920

Closed

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 4, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

8a7d7be

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 4, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

04b0cde

…ses in UnusedLocalVariableCheck

Vyom-Yadav mentioned this issue Mar 4, 2023

Issue #11374: Fix false positive related to anon inner classes in UnusedLocalVariableCheck #12795

Closed

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 4, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

1476e0e

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 4, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

3e532cd

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 7, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

3e02035

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 7, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

60d624e

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 8, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

ad659e1

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 28, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

28054c4

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 28, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

437ea00

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 7, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

eca1f20

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 30, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

6bf000e

…ses in UnusedLocalVariableCheck

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Nov 30, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

8e312b0

…ses in UnusedLocalVariableCheck

romani pushed a commit to Vyom-Yadav/checkstyle that referenced this issue Dec 1, 2023

Issue checkstyle#11374: Fix false positive related to anon inner clas…

4183859

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Nov 29, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

ab40e91

…ses in UnusedLocalVariableCheck

kkoutsilis mentioned this issue Nov 29, 2024

Issue #11374: Fix false positive related to anon inner classes in UnusedLocalVariableCheck #15969

Merged

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Nov 29, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

293686d

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Dec 2, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

bed3844

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Dec 7, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

7c213d4

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Dec 7, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

9ffee19

…ses in UnusedLocalVariableCheck

romani pushed a commit to kkoutsilis/checkstyle that referenced this issue Dec 7, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

7b5184d

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Dec 7, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

cf6d56c

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Dec 8, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

29c8ef5

…ses in UnusedLocalVariableCheck

kkoutsilis added a commit to kkoutsilis/checkstyle that referenced this issue Dec 14, 2024

Issue checkstyle#11374: Fix false positive related to anon inner clas…

cd2b2e0

…ses in UnusedLocalVariableCheck

nrmancuso pushed a commit that referenced this issue Dec 16, 2024

Issue #11374: Fix false positive related to anon inner classes in Unu…

9d813e1

…sedLocalVariableCheck

nrmancuso closed this as completed in #15969 Dec 16, 2024

github-actions bot added this to the 10.21.1 milestone Dec 16, 2024

nrmancuso added the bug label Dec 16, 2024

romani changed the title ~~False Positive: UnusedLocalVariableCheck~~ UnusedLocalVariable: False Positive when inner class has same field as variable Dec 27, 2024

wayneguow mentioned this issue Feb 12, 2025

[SPARK-51171][BUILD] Upgrade checkstyle to 10.21.2 apache/spark#49899

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UnusedLocalVariable: False Positive when inner class has same field as variable #11374

UnusedLocalVariable: False Positive when inner class has same field as variable #11374

Vyom-Yadav commented Mar 7, 2022 •

edited

Loading

Vyom-Yadav commented Mar 22, 2022 •

edited

Loading

nrmancuso commented Dec 16, 2024

UnusedLocalVariable: False Positive when inner class has same field as variable #11374

UnusedLocalVariable: False Positive when inner class has same field as variable #11374

Comments

Vyom-Yadav commented Mar 7, 2022 • edited Loading

Vyom-Yadav commented Mar 22, 2022 • edited Loading

nrmancuso commented Dec 16, 2024

Vyom-Yadav commented Mar 7, 2022 •

edited

Loading

Vyom-Yadav commented Mar 22, 2022 •

edited

Loading