Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FinalClassCheck: False positive with anonymous classes #11365

Closed
Vyom-Yadav opened this issue Mar 6, 2022 · 2 comments · Fixed by #11468
Closed

FinalClassCheck: False positive with anonymous classes #11365

Vyom-Yadav opened this issue Mar 6, 2022 · 2 comments · Fixed by #11468
Labels
approved bug
Milestone
10.3.1

Comments

@Vyom-Yadav
Copy link
Member

Vyom-Yadav commented Mar 6, 2022 •
edited
Loading

I have read check documentation: https://checkstyle.sourceforge.io/config_design.html#FinalClass
I have downloaded the latest checkstyle from: https://checkstyle.org/cmdline.html#Download_and_Run
I have executed the cli and showed it below, as cli describes the problem better than 1,000 words

/var/tmp $ javac Test.java

/var/tmp $ cat config.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
        "https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="Checker">
    <module name="TreeWalker">
        <module name="FinalClass"/>
    </module>
</module>
/var/tmp $ cat Test.java

public class Test {

    class a { // expected no violation
        private a() {
        }
    }

    a obj = new a() {
    };
}
/var/tmp $ RUN_LOCALE="-Duser.language=en -Duser.country=US"
/var/tmp $ java $RUN_LOCALE -jar checkstyle-10.0-all.jar -c config.xml Test.java
Starting audit...
[ERROR] /var/tmp/Test.java:3:5: Class a should be declared as final. [FinalClass]
Audit done.
Checkstyle ends with 1 errors.

Describe what you expect in detail.

/var/tmp $ RUN_LOCALE="-Duser.language=en -Duser.country=US"
/var/tmp $ java $RUN_LOCALE -jar checkstyle-10.0-all.jar -c config.xml Test.java
Starting audit...
Audit done.

This was supposed to be fixed in #9357. Making the class final results in a compile-time error.
@Vyom-Yadav
Copy link
Member Author

I am on it.

@romani romani added the approved label Mar 6, 2022
This was referenced Mar 6, 2022
Merged
Closed
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
3745e1e 
…es in FinalClassCheck
@Vyom-Yadav Vyom-Yadav mentioned this issue Mar 26, 2022
Closed
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
5a88f91 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
cfbba33 
…es in FinalClassCheck
This was referenced Mar 26, 2022
Closed
Merged
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 26, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
b303c71 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
9e57a88 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
6a7db5c 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
37c01d6 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
7130cad 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Mar 31, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
e783a24 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 1, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
328ef7b 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 3, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
02e9fda 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 3, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
f012fe3 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 3, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
a48f4c8 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 4, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
514d736 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 4, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
25afbb6 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 8, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
3a9040c 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 8, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
87298e9 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 8, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
a7c0cbf 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 12, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
d9e7da3 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 12, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
a62b1e8 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 12, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
92f8b18 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 12, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
bacb862 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 13, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
758bcc7 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 13, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
871b2df 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 24, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
9e1684a 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Apr 24, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
7bb71ff 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 6, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
0dfc2ee 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 7, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
15c1081 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 15, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
9da4eb2 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 15, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
7c68725 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 15, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
1182d94 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 15, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
af6ee32 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 15, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
b4bef76 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 17, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
95a5af9 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 18, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
edd670a 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 18, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
eae30d4 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue May 21, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
be7381c 
…es in FinalClassCheck
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 8, 2022
@Vyom-Yadav
Issue checkstyle#11365: Fix false positive with anonymous inner class…
f68b208 
…es in FinalClassCheck
romani pushed a commit that referenced this issue Jun 8, 2022
@Vyom-Yadav @romani
Issue #11365: Fix false positive with anonymous inner classes in Fina…
cd28d8c 
…lClassCheck
@romani romani added the bug label Jun 8, 2022
@romani romani added this to the 10.4 milestone Jun 8, 2022
@romani
Copy link
Member

romani commented Jun 8, 2022

fix is merged

@Rahulkhinchi03 Rahulkhinchi03 mentioned this issue Jul 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved bug
Projects
None yet
Milestone
10.3.1
2 participants
@romani @Vyom-Yadav