Skip to content

Commit e4b625a

Browse files
Harsh-Agrawal96romani
Harsh-Agrawal96
authored and
romani
committed
Issue #13999: resolve pitest Suppression for JavadocStyleCheck
1 parent 203ce2e commit e4b625a

4 files changed

Lines changed: 35 additions & 45 deletions

File tree

‎config/checkstyle-resources-suppressions.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@
100100
files="[\\/]InputRegexpTrailingComment10\.java"/>
101101
<suppress id="noTrailingWhitespace"
102102
files="[\\/]InputRegexpSinglelineJavaTrailingComment10\.java"/>
103+
<suppress id="noTrailingWhitespace"
104+
files="[\\/]javadocstyle[\\/]InputJavadocStyleTrailingSpace\.java"/>
103105

104106
<!-- Input file contains trailing whitespace to kill pitest mutation -->
105107
<suppress id="noTrailingWhitespace"

‎config/pitest-suppressions/pitest-javadoc-suppressions.xml‎

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -63,51 +63,6 @@
6363
<lineContent>+ &quot;, children=&quot; + Objects.hashCode(children)</lineContent>
6464
</mutation>
6565

66-
<mutation unstable="false">
67-
<sourceFile>JavadocStyleCheck.java</sourceFile>
68-
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
69-
<mutatedMethod>trimTail</mutatedMethod>
70-
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
71-
<description>removed call to java/lang/StringBuilder::deleteCharAt</description>
72-
<lineContent>builder.deleteCharAt(index);</lineContent>
73-
</mutation>
74-
75-
<mutation unstable="false">
76-
<sourceFile>JavadocStyleCheck.java</sourceFile>
77-
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
78-
<mutatedMethod>trimTail</mutatedMethod>
79-
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
80-
<description>replaced call to java/lang/StringBuilder::deleteCharAt with receiver</description>
81-
<lineContent>builder.deleteCharAt(index);</lineContent>
82-
</mutation>
83-
84-
<mutation unstable="false">
85-
<sourceFile>JavadocStyleCheck.java</sourceFile>
86-
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
87-
<mutatedMethod>trimTail</mutatedMethod>
88-
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
89-
<description>removed call to java/lang/Character::isWhitespace</description>
90-
<lineContent>if (Character.isWhitespace(builder.charAt(index))) {</lineContent>
91-
</mutation>
92-
93-
<mutation unstable="false">
94-
<sourceFile>JavadocStyleCheck.java</sourceFile>
95-
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
96-
<mutatedMethod>trimTail</mutatedMethod>
97-
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
98-
<description>removed call to java/lang/StringBuilder::charAt</description>
99-
<lineContent>if (Character.isWhitespace(builder.charAt(index))) {</lineContent>
100-
</mutation>
101-
102-
<mutation unstable="false">
103-
<sourceFile>JavadocStyleCheck.java</sourceFile>
104-
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck</mutatedClass>
105-
<mutatedMethod>trimTail</mutatedMethod>
106-
<mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
107-
<description>removed conditional - replaced equality check with false</description>
108-
<lineContent>if (Character.isWhitespace(builder.charAt(index))) {</lineContent>
109-
</mutation>
110-
11166
<mutation unstable="false">
11267
<sourceFile>JavadocTagInfo.java</sourceFile>
11368
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagInfo$11</mutatedClass>

‎src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocStyleCheckTest.java‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,15 @@ public void testJavadocStyleDefaultSettingsFive()
143143
getPath("InputJavadocStyleDefaultSettingsFive.java"), expected);
144144
}
145145

146+
@Test
147+
public void testJavadocStyleTrailingSpace()
148+
throws Exception {
149+
final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
150+
151+
verifyWithInlineConfigParser(
152+
getPath("InputJavadocStyleTrailingSpace.java"), expected);
153+
}
154+
146155
@Test
147156
public void testJavadocStyleFirstSentenceOne() throws Exception {
148157
final String[] expected = {

‎src/test/resources/com/puppycrawl/tools/checkstyle/checks/javadoc/javadocstyle/InputJavadocStyleTrailingSpace.java‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
/*
2+
JavadocStyle
3+
scope = (default)private
4+
excludeScope = (default)null
5+
checkFirstSentence = (default)true
6+
endOfSentenceFormat = ([.?!][\n\r\f<])
7+
checkEmptyJavadoc = (default)false
8+
checkHtml = false
9+
tokens = (default)ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, \
10+
ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, PACKAGE_DEF, \
11+
VARIABLE_DEF, RECORD_DEF, COMPACT_CTOR_DEF
12+
13+
14+
*/
15+
16+
package com.puppycrawl.tools.checkstyle.checks.javadoc.javadocstyle;
17+
18+
public class InputJavadocStyleTrailingSpace {
19+
/**
20+
* This is the last line.
21+
* This is the last line.
22+
*/
23+
public void exampleMethod() { }
24+
}

0 commit comments

Comments
 (0)