Issue #15456: Violation message for SuperCloneCheck

shaikhu · romani · commit e1dc3abaa59f · 2025-02-28T20:16:51.000-08:00
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java
@@ -227,7 +227,6 @@ public final class InlineConfigParser {
             "com.puppycrawl.tools.checkstyle.checks.coding.NestedTryDepthCheck",
             "com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck",
             "com.puppycrawl.tools.checkstyle.checks.coding.StringLiteralEqualityCheck",
-            "com.puppycrawl.tools.checkstyle.checks.coding.SuperCloneCheck",
             "com.puppycrawl.tools.checkstyle.checks.coding.SuperFinalizeCheck",
             "com.puppycrawl.tools.checkstyle.checks.coding"
                     + ".UnnecessarySemicolonAfterTypeMemberDeclarationCheck",
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java
@@ -49,7 +49,7 @@ public void testIt() throws Exception {
         final String[] expected = {
             "33:19: " + getCheckMessage(MSG_KEY, "clone", "super.clone"),
             "41:19: " + getCheckMessage(MSG_KEY, "clone", "super.clone"),
-            "66:48: " + getCheckMessage(MSG_KEY, "clone", "super.clone"),
+            "67:48: " + getCheckMessage(MSG_KEY, "clone", "super.clone"),
         };
         verifyWithInlineConfigParser(
                 getPath("InputSuperCloneInnerAndWithArguments.java"), expected);
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperCloneInnerAndWithArguments.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperCloneInnerAndWithArguments.java
@@ -30,15 +30,15 @@ public void method() throws CloneNotSupportedException
 
 class NoSuperClone
 {
-    public Object clone() // violation
+    public Object clone() // violation "Method 'clone' should call 'super.clone'"
     {
         return null;
     }
 }
 
 class InnerClone
 {
-    public Object clone() // violation
+    public Object clone() // violation "Method 'clone' should call 'super.clone'"
     {
         class Inner
         {
@@ -63,7 +63,8 @@ public CloneWithTypeArguments<T> clone() throws CloneNotSupportedException
 
 class CloneWithTypeArgumentsAndNoSuper<T>
 {
-    public CloneWithTypeArgumentsAndNoSuper<T> clone() // violation
+    // violation below "Method 'clone' should call 'super.clone'"
+    public CloneWithTypeArgumentsAndNoSuper<T> clone()
             throws CloneNotSupportedException
     {
         return null;
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperClonePlainAndSubclasses.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/coding/superclone/InputSuperClonePlainAndSubclasses.java
@@ -11,7 +11,7 @@ interface InputSuperClonePlainAndSubclasses {
 }
 
 class A {
-  public Object clone() { // violation
+  public Object clone() { // violation "Method 'clone' should call 'super.clone'"
       return null;
   }
 }
@@ -44,8 +44,8 @@ public void run() {
 }
 
 class D extends B {
-
-  public Object clone() throws CloneNotSupportedException { // violation
+  // violation below "Method 'clone' should call 'super.clone'"
+  public Object clone() throws CloneNotSupportedException {
     super.clone(null, null);
     return null;
   }

Original file line number	Diff line number	Diff line change
`@@ -30,15 +30,15 @@ public void method() throws CloneNotSupportedException`
`30`	`30`
`31`	`31`	`class NoSuperClone`
`32`	`32`	`{`
`33`		`- public Object clone() // violation`
	`33`	`+ public Object clone() // violation "Method 'clone' should call 'super.clone'"`
`34`	`34`	`{`
`35`	`35`	`return null;`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`class InnerClone`
`40`	`40`	`{`
`41`		`- public Object clone() // violation`
	`41`	`+ public Object clone() // violation "Method 'clone' should call 'super.clone'"`
`42`	`42`	`{`
`43`	`43`	`class Inner`
`44`	`44`	`{`
`@@ -63,7 +63,8 @@ public CloneWithTypeArguments<T> clone() throws CloneNotSupportedException`
`63`	`63`
`64`	`64`	`class CloneWithTypeArgumentsAndNoSuper<T>`
`65`	`65`	`{`
`66`		`- public CloneWithTypeArgumentsAndNoSuper<T> clone() // violation`
	`66`	`+ // violation below "Method 'clone' should call 'super.clone'"`
	`67`	`+ public CloneWithTypeArgumentsAndNoSuper<T> clone()`
`67`	`68`	`throws CloneNotSupportedException`
`68`	`69`	`{`
`69`	`70`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ interface InputSuperClonePlainAndSubclasses {`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`class A {`
`14`		`- public Object clone() { // violation`
	`14`	`+ public Object clone() { // violation "Method 'clone' should call 'super.clone'"`
`15`	`15`	`return null;`
`16`	`16`	`}`
`17`	`17`	`}`
`@@ -44,8 +44,8 @@ public void run() {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`class D extends B {`
`47`		`-`
`48`		`- public Object clone() throws CloneNotSupportedException { // violation`
	`47`	`+ // violation below "Method 'clone' should call 'super.clone'"`
	`48`	`+ public Object clone() throws CloneNotSupportedException {`
`49`	`49`	`super.clone(null, null);`
`50`	`50`	`return null;`
`51`	`51`	`}`