Issue #18926: Re-enable RedundantSuppression inspection

vivek-0509 · romani · commit 427acbff485b · 2026-02-26T05:39:49.000-08:00
diff --git a/config/intellij-idea-inspections.xml b/config/intellij-idea-inspections.xml
@@ -3774,9 +3774,8 @@
                    enabled_by_default="false"/>
   <inspection_tool class="RedundantStringFormatCall" enabled="true" level="ERROR"
                    enabled_by_default="true"/>
-  <!-- temporary disabled until https://github.com/checkstyle/checkstyle/issues/18926 -->
-  <inspection_tool class="RedundantSuppression" enabled="false" level="ERROR"
-                   enabled_by_default="false"/>
+  <inspection_tool class="RedundantSuppression" enabled="true" level="ERROR"
+                   enabled_by_default="true"/>
   <inspection_tool class="RedundantSuspendModifier" enabled="false" level="WARNING"
                    enabled_by_default="false"/>
   <inspection_tool class="RedundantThrows" enabled="true" level="ERROR"
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java
@@ -25,9 +25,6 @@
  * A Java Bean that implements the component lifecycle interfaces by
  * calling the bean's setters for all configuration attributes.
  *
- * @noinspection AbstractClassNeverImplemented
- * @noinspectionreason All files now use {@code AbstractAutomaticBean}.
- *     We will remove this class in #12873.
  * @deprecated since 10.9.3. Use {@code AbstractAutomaticBean} instead.
  */
 // -@cs[AbstractClassName] We can not break compatibility with previous versions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedCheck.java
@@ -122,8 +122,6 @@ public int[] getRequiredJavadocTokens() {
      * @param shouldReportViolation value to which the field shall be set to
      * @since 8.3
      * @propertySince 8.24
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setViolateExecutionOnNonTightHtml(boolean shouldReportViolation) {
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheck.java
@@ -56,8 +56,6 @@ public int[] getDefaultJavadocTokens() {
      *
      * @param strRep the string representation of the tokens interested in
      * @propertySince 7.3
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setJavadocTokens(String... strRep) {
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassDataAbstractionCouplingCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassDataAbstractionCouplingCheck.java
@@ -129,8 +129,6 @@ protected String getLogMessageId() {
      *
      * @param from array representing regular expressions of classes to ignore.
      * @propertySince 7.7
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setExcludeClassesRegexps(Pattern... from) {
@@ -142,8 +140,6 @@ public void setExcludeClassesRegexps(Pattern... from) {
      *
      * @param excludedClasses classes to ignore.
      * @propertySince 5.7
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setExcludedClasses(String... excludedClasses) {
@@ -156,8 +152,6 @@ public void setExcludedClasses(String... excludedClasses) {
      * @param excludedPackages packages to ignore.
      * @throws IllegalArgumentException if there are invalid identifiers among the packages.
      * @propertySince 7.7
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setExcludedPackages(String... excludedPackages) {
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheck.java
@@ -101,8 +101,6 @@ protected String getLogMessageId() {
      *
      * @param from array representing regular expressions of classes to ignore.
      * @propertySince 7.7
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setExcludeClassesRegexps(Pattern... from) {
@@ -114,8 +112,6 @@ public void setExcludeClassesRegexps(Pattern... from) {
      *
      * @param excludedClasses classes to ignore.
      * @propertySince 5.7
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setExcludedClasses(String... excludedClasses) {
@@ -128,8 +124,6 @@ public void setExcludedClasses(String... excludedClasses) {
      * @param excludedPackages packages to ignore.
      * @throws IllegalArgumentException if there are invalid identifiers among the packages.
      * @propertySince 7.7
-     * @noinspection RedundantMethodOverride
-     * @noinspectionreason Display module's unique property version
      */
     @Override
     public void setExcludedPackages(String... excludedPackages) {

Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,6 @@ public int[] getDefaultJavadocTokens() {`
`56`	`56`	`*`
`57`	`57`	`* @param strRep the string representation of the tokens interested in`
`58`	`58`	`* @propertySince 7.3`
`59`		`- * @noinspection RedundantMethodOverride`
`60`		`- * @noinspectionreason Display module's unique property version`
`61`	`59`	`*/`
`62`	`60`	`@Override`
`63`	`61`	`public void setJavadocTokens(String... strRep) {`