Issue #13345: enable test for AvoidNoArgumentSuperConstructorCallCheck

Lmh-java · nrmancuso · commit 387087546392 · 2024-03-10T16:57:50.000-04:00
diff --git a/src/xdocs-examples/java/com/puppycrawl/tools/checkstyle/checks/coding/AvoidNoArgumentSuperConstructorCallCheckExamplesTest.java b/src/xdocs-examples/java/com/puppycrawl/tools/checkstyle/checks/coding/AvoidNoArgumentSuperConstructorCallCheckExamplesTest.java
@@ -19,12 +19,12 @@
 
 package com.puppycrawl.tools.checkstyle.checks.coding;
 
-import org.junit.jupiter.api.Disabled;
+import static com.puppycrawl.tools.checkstyle.checks.coding.AvoidNoArgumentSuperConstructorCallCheck.MSG_CTOR;
+
 import org.junit.jupiter.api.Test;
 
 import com.puppycrawl.tools.checkstyle.AbstractExamplesModuleTestSupport;
 
-@Disabled("until https://github.com/checkstyle/checkstyle/issues/13345")
 public class AvoidNoArgumentSuperConstructorCallCheckExamplesTest
         extends AbstractExamplesModuleTestSupport {
     @Override
@@ -35,9 +35,9 @@ protected String getPackageLocation() {
     @Test
     public void testExample1() throws Exception {
         final String[] expected = {
-
+            "17:5: " + getCheckMessage(MSG_CTOR),
         };
 
-        verifyWithInlineConfigParser(getPath("Example1.txt"), expected);
+        verifyWithInlineConfigParser(getPath("Example1.java"), expected);
     }
 }
diff --git a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.java b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.java
@@ -0,0 +1,28 @@
+/*xml
+<module name="Checker">
+  <module name="TreeWalker">
+    <module name="AvoidNoArgumentSuperConstructorCall"/>
+  </module>
+</module>
+*/
+package com.puppycrawl.tools.checkstyle.checks.coding.avoidnoargumentsuperconstructorcall;
+
+// xdoc section -- start
+class SuperClass {
+  public SuperClass() {}
+  public SuperClass(int arg) {}
+}
+class Example1 extends SuperClass {
+  Example1() {
+    super(); // violation
+  }
+
+  Example1(int arg) {
+    super(arg); // ok, explicit constructor invocation with argument
+  }
+
+  Example1(long arg) {
+    // ok, no explicit constructor invocation
+  }
+}
+// xdoc section -- end
diff --git a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.txt b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.txt
diff --git a/src/xdocs/checks/coding/avoidnoargumentsuperconstructorcall.xml b/src/xdocs/checks/coding/avoidnoargumentsuperconstructorcall.xml
@@ -33,18 +33,22 @@
           Example of violations
         </p>
         <source>
-class MyClass extends SomeOtherClass {
-    MyClass() {
-        super(); // violation
-    }
+class SuperClass {
+  public SuperClass() {}
+  public SuperClass(int arg) {}
+}
+class Example1 extends SuperClass {
+  Example1() {
+    super(); // violation
+  }
 
-    MyClass(int arg) {
-        super(arg); // OK, call with argument have to be explicit
-    }
+  Example1(int arg) {
+    super(arg); // ok, explicit constructor invocation with argument
+  }
 
-    MyClass(long arg) {
-        // OK, call is implicit
-    }
+  Example1(long arg) {
+    // ok, no explicit constructor invocation
+  }
 }
         </source>
       </subsection>
diff --git a/src/xdocs/checks/coding/avoidnoargumentsuperconstructorcall.xml.template b/src/xdocs/checks/coding/avoidnoargumentsuperconstructorcall.xml.template
@@ -24,15 +24,15 @@
         </p>
         <macro name="example">
           <param name="path"
-                 value="resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.txt"/>
+                 value="resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.java"/>
           <param name="type" value="config"/>
         </macro>
         <p id="Example1-code">
           Example of violations
         </p>
         <macro name="example">
           <param name="path"
-                 value="resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.txt"/>
+                 value="resources/com/puppycrawl/tools/checkstyle/checks/coding/avoidnoargumentsuperconstructorcall/Example1.java"/>
           <param name="type" value="code"/>
         </macro>
       </subsection>
