Issue #13321: Kill mutation for CheckUtil-5

Kevin222004 · romani · commit 19f4925489b6 · 2023-07-29T15:27:47.000-07:00
diff --git a/config/pitest-suppressions/pitest-utils-suppressions.xml b/config/pitest-suppressions/pitest-utils-suppressions.xml
@@ -27,23 +27,23 @@
     <lineContent>&amp;&amp; parent.getParent().getType() == memberType</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>CheckUtil.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CheckUtil</mutatedClass>
-    <mutatedMethod>getAccessModifierFromModifiersToken</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
-    <description>removed conditional - replaced equality check with true</description>
-    <lineContent>if (ScopeUtil.isInEnumBlock(ast) &amp;&amp; ast.getType() == TokenTypes.CTOR_DEF) {</lineContent>
-  </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>CheckUtil.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.utils.CheckUtil</mutatedClass>
-    <mutatedMethod>getAccessModifierFromModifiersToken</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_IF</mutator>
-    <description>removed conditional - replaced equality check with true</description>
-    <lineContent>if (accessModifier == AccessModifierOption.PACKAGE) {</lineContent>
-  </mutation>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
   <mutation unstable="false">
     <sourceFile>CheckUtil.java</sourceFile>
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilTest.java
@@ -23,6 +23,7 @@
 import static com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck.MSG_EQUALS_AVOID_NULL;
 import static com.puppycrawl.tools.checkstyle.checks.coding.MultipleVariableDeclarationsCheck.MSG_MULTIPLE;
 import static com.puppycrawl.tools.checkstyle.checks.coding.NestedIfDepthCheck.MSG_KEY;
+import static com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.MSG_EXPECTED_TAG;
 import static com.puppycrawl.tools.checkstyle.internal.utils.TestUtil.findTokenInAstByPredicate;
 import static com.puppycrawl.tools.checkstyle.internal.utils.TestUtil.isUtilsClassHasPrivateConstructor;
 
@@ -43,6 +44,7 @@
 import com.puppycrawl.tools.checkstyle.checks.coding.EqualsAvoidNullCheck;
 import com.puppycrawl.tools.checkstyle.checks.coding.MultipleVariableDeclarationsCheck;
 import com.puppycrawl.tools.checkstyle.checks.coding.NestedIfDepthCheck;
+import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck;
 import com.puppycrawl.tools.checkstyle.checks.naming.AccessModifierOption;
 
 public class CheckUtilTest extends AbstractModuleTestSupport {
@@ -481,6 +483,23 @@ public void testNestedIfDepth() throws Exception {
                 getPath("InputCheckUtil3.java"), expected);
     }
 
+    @Test
+    public void testJavaDocMethod() throws Exception {
+        final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
+        verifyWithInlineConfigParser(
+                getPath("InputCheckUtil4.java"), expected);
+    }
+
+    @Test
+    public void testJavaDocMethod2() throws Exception {
+        final String[] expected = {
+            "14:25: " + getCheckMessage(JavadocMethodCheck.class,
+                  MSG_EXPECTED_TAG, "@param", "i"),
+        };
+        verifyWithInlineConfigParser(
+                getPath("InputCheckUtil5.java"), expected);
+    }
+
     private DetailAST getNodeFromFile(int type) throws Exception {
         return getNode(JavaParser.parseFile(new File(getPath("InputCheckUtilTest.java")),
             JavaParser.Options.WITH_COMMENTS), type);
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/utils/checkutil/InputCheckUtil4.java b/src/test/resources/com/puppycrawl/tools/checkstyle/utils/checkutil/InputCheckUtil4.java
@@ -0,0 +1,21 @@
+/*
+com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck
+accessModifiers = public
+
+*/
+
+package com.puppycrawl.tools.checkstyle.utils.checkutil;
+
+// ok
+public interface InputCheckUtil4 {
+
+    /**
+     *  Description.
+     *
+     * @param it it
+     * @param column coloumn
+     */
+    private InputCheckUtil4 method(int it, int column) {
+        return null;
+    }
+}
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/utils/checkutil/InputCheckUtil5.java b/src/test/resources/com/puppycrawl/tools/checkstyle/utils/checkutil/InputCheckUtil5.java
@@ -0,0 +1,16 @@
+/*
+com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck
+accessModifiers = package
+
+*/
+
+package com.puppycrawl.tools.checkstyle.utils.checkutil;
+
+final class InputCheckUtil5 {
+
+    /**
+     * Description.
+     */
+    InputCheckUtil5(int i) { // violation 'Expected @param tag for 'i''
+    }
+}
