Skip to content

Replace libprotobuf-c0-dev with libprotobuf-c-dev#743

Merged
avagin merged 1 commit intocheckpoint-restore:criu-devfrom
thaJeztah:replace_libprotobuf_c0_dev
Jul 17, 2019
Merged

Replace libprotobuf-c0-dev with libprotobuf-c-dev#743
avagin merged 1 commit intocheckpoint-restore:criu-devfrom
thaJeztah:replace_libprotobuf_c0_dev

Conversation

@thaJeztah
Copy link
Copy Markdown
Contributor

@thaJeztah thaJeztah commented Jul 17, 2019

The libprotobuf-c0-dev virtual package is no longer available
in Debian Buster, but is provided by libprotobuf-c-dev, which
is available.

https://packages.debian.org/stretch/libprotobuf-c0-dev

Virtual Package: libprotobuf-c0-dev

This is a virtual package. See the Debian policy for a definition of virtual packages.

Packages providing libprotobuf-c0-dev
libprotobuf-c-dev
Protocol Buffers C static library and headers (protobuf-c)

@thaJeztah
Replace libprotobuf-c0-dev with libprotobuf-c-dev
72f0851 
The `libprotobuf-c0-dev` virtual package is no longer available
in Debian Buster, but is provided by `libprotobuf-c-dev`, which
is available.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Jul 17, 2019
Merged
6 tasks
@thaJeztah
Copy link
Copy Markdown
Contributor Author

thaJeztah commented Jul 17, 2019

Looks like CI completed, but didn't report back

@thaJeztah
Copy link
Copy Markdown
Contributor Author

thaJeztah commented Jul 17, 2019

ping @avagin @kolyshkin ptal 🤗

@adrianreber
Copy link
Copy Markdown
Member

adrianreber commented Jul 17, 2019

So Debian 9 is Stretch and Debian 10 is Buster, right? Those are the two currently active releases, right? And both releases have libprotobuf-c-dev, right? But the Dockerfile and travis scripts are running on Ubuntu 16.04 (I think). Is the package on Ubuntu also named without the 0? Looking at the travis result everything still seems to work and I also see it without 0 on 18.04. So 👍 from me.

@thaJeztah
Copy link
Copy Markdown
Contributor Author

thaJeztah commented Jul 17, 2019

oh, ahum, yes I came to this because I ran into the problem in moby/moby#39549 and assumed you're using Debian here (😊😅) ; I'll double-check the Ubuntu packages, but they're very likely the same (😅)

@avagin
Copy link
Copy Markdown
Member

avagin commented Jul 17, 2019

I don't seen any problem with Debian. Our s390 job uses the s390x/debian:latest base image:
https://travis-ci.org/checkpoint-restore/criu/jobs/559945752

@avagin avagin merged commit 01b2ec7 into checkpoint-restore:criu-dev Jul 17, 2019
@avagin
Copy link
Copy Markdown
Member

avagin commented Jul 17, 2019

Applied, thanks!

@thaJeztah thaJeztah deleted the replace_libprotobuf_c0_dev branch July 17, 2019 18:06
@thaJeztah
Copy link
Copy Markdown
Contributor Author

thaJeztah commented Jul 17, 2019

Thanks!

@thaJeztah thaJeztah mentioned this pull request Jul 20, 2019
Closed
@kolyshkin kolyshkin mentioned this pull request Aug 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @adrianreber @avagin