Skip to content

Append new line between records when using custom --format#98

Merged
obnoxxx merged 2 commits intocheckmake:mainfrom
adelplanque:fix-new-line
Aug 25, 2025
Merged

Append new line between records when using custom --format#98
obnoxxx merged 2 commits intocheckmake:mainfrom
adelplanque:fix-new-line

Conversation

@adelplanque
Copy link
Copy Markdown
Contributor

@adelplanque adelplanque commented May 8, 2024

According to the documentation, when using the --format option, each error report must end with a new line, which is not the case.

Checklist

Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

  • CI passes
  • [ X] Description of proposed change
  • [ X] Documentation (README, docs/, man pages) is updated
  • Existing issue is referenced if there is one
  • [ X] Unit tests for the proposed change

@adelplanque
Copy link
Copy Markdown
Contributor Author

I just saw #55, but in #54 only deletion of \r was requested.
All lint tools I know use a breakline between error reports. The standard under Unix is a simple \n. That's why I think it would be a good idea to restore a \n at the end of each error.
Even if we obtain the same effect with {{"\n"}}, this seems to me a tricky way of proceeding for someone who does not know the Go language.
A better solution might be to add \r\n or \n depending on the OS.

@obnoxxx
Copy link
Copy Markdown
Collaborator

obnoxxx commented Jun 11, 2025

rebased on current mainbranch.

Copy link
Copy Markdown
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@obnoxxx obnoxxx merged commit 542782e into checkmake:main Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants