Reduces files to the built-in makefile type for pre-commit#77
Merged
mrtazz merged 1 commit intocheckmake:mainfrom Jan 26, 2023
Merged
Reduces files to the built-in makefile type for pre-commit#77mrtazz merged 1 commit intocheckmake:mainfrom
mrtazz merged 1 commit intocheckmake:mainfrom
Conversation
As nudged [here][1], but this won't be fully effective until pre-commit/identify#353 is merged. I think this is safe because so few people use `*.make`... I think I've seen it maybe a few times in 20 years. [1]: pre-commit/pre-commit.com#756 (comment)
4 tasks
Contributor
Author
|
All of the upstream stuff is merged, so this can go in, @mrtazz |
Contributor
Author
|
@mrtazz this is safe to merge now |
Contributor
Author
|
@mrtazz Any chance for a merge? |
Collaborator
|
sorry for the delay. Thanks for taking the time to contribute |
Contributor
Author
|
Thank you! Could you perhaps do a release so that folks using the pre-commit hook can point to a tag instead of a hash? |
Contributor
Author
|
@mrtazz Any chance for a tag? |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As nudged here, but this won't be fully effective until pre-commit/identify#353 is merged.
I think this is safe to merge before 353 because so few people use
*.make... I think I've seen it maybe a few times in 20 years. Also, this hook is so new to checkmake that probably not that many people are using it yet.Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.