fix(cli): cleanup --version output#228
Merged
obnoxxx merged 1 commit intocheckmake:mainfrom Jan 9, 2026
Merged
Conversation
Collaborator
|
LGTM |
obnoxxx
requested changes
Jan 9, 2026
Collaborator
obnoxxx
left a comment
obnoxxx
left a comment
There was a problem hiding this comment.
The change itself looks good to me but please ad a signoff line to you commit message, e. g by running git commit --amend -s
Striped the surplus leading "checkmake version" in `--version` output. https://github.com/spf13/cobra/blob/main/site/content/user_guide.md#version-flag $ checkmake --version # before, with v0.3.0 checkmake version checkmake vx.y.x ... # after checkmake vx.y.x ... Signed-off-by: Yukai Chou <[email protected]>
muzimuzhi
force-pushed
the
fix/version-output
branch
from
ddec497 to
ec6a177
Compare
Contributor
Author
|
@obnoxxx Sign-off-by trailer added. |
obnoxxx
approved these changes
Jan 9, 2026
Collaborator
obnoxxx
left a comment
obnoxxx
left a comment
There was a problem hiding this comment.
Thanks for adjusting the commit message! This LGTM now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Striped the surplus leading "checkmake version" in
--versionoutput.https://github.com/spf13/cobra/blob/main/site/content/user_guide.md#version-flag
I spot the changed pattern of
checkmake --versionoutput from a brokenmiseCI.Tested locally by executing
make clean all test.Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.