ensure required PHONY targets also exist as real targets#173
Merged
obnoxxx merged 1 commit intocheckmake:mainfrom Oct 17, 2025
Merged
ensure required PHONY targets also exist as real targets#173obnoxxx merged 1 commit intocheckmake:mainfrom
obnoxxx merged 1 commit intocheckmake:mainfrom
Conversation
The minphony rule now validates that required targets are both: - declared as PHONY, and - actually defined in the Makefile. Fixes checkmake#172 Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
obnoxxx
approved these changes
Oct 17, 2025
Collaborator
obnoxxx
left a comment
obnoxxx
left a comment
There was a problem hiding this comment.
Thanks for this fix!
I tested it locally.
Works like a charm.
LGTM
This was referenced Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minphony rule now validates that required targets are both:
Fixes: #172
Fixes: #87