Skip to content

config can not override default minphony required targets #113

@obnoxxx

Description

@obnoxxx

It is currently not possible to override the default required minphony targets in the config.

I think this should work, e. g. with a config file like this:

[minphony]
required=foo,bar

But it does in fact not work while maxbodylength does:

$ cat ./checkmake.ini 
[maxbodylength]
maxBodyLength=8
[minphony]
required="foo bar"

$ cat test.mk 


.PHONY: long
long:
	@echo 1
	@echo 2
	@echo 3
	@echo 4
	@echo 5
	@echo 6
	@echo 7
	@echo 8
	@echo 9


$./checkmake --config=./checkmake.ini  test.mk
      RULE                 DESCRIPTION             FILE NAME   LINE NUMBER  
                                                                            
  maxbodylength   Target body for "long" exceeds   test.mk     4            
                  allowed length of 8 lines (9).                            
  minphony        Missing required phony target    test.mk     3            
                  "all"                                                     
  minphony        Missing required phony target    test.mk     3            
                  "clean"                                                   
  minphony        Missing required phony target    test.mk     3            
                  "test"                                                    

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions