Repository navigation
test(models): pin qwen3.8-max resolution per provider, not across all four - #11590
Merged
diegosouzapw merged 2 commits intoAug 26, 2026
Conversation
… four
`Unit Tests fast-path` is red on every branch:
✖ chatCore lifecycle resolution rewrites the model before dispatch
resolvedModel for qwen-cloud-token-plan
actual: 'qwen3.8-max', expected: 'qwen3.8-max-preview'
The test's premise — "the model ships everywhere as `qwen3.8-max-preview`
(bailian-coding-plan, qoder, qwen-cloud-token-plan, qwen-web)" — has half expired.
Probed against the live catalogs:
qwen-cloud-token-plan -> ["qwen3.8-max"] hasKnownProviderModel(bare) = true
qwen-web -> ["qwen3.8-max"] hasKnownProviderModel(bare) = true
qoder -> ["qwen3.8-max-preview"] hasKnownProviderModel(bare) = false
bailian-coding-plan -> ["qwen3.8-max-preview"] hasKnownProviderModel(bare) = false
Two of the four now list the BARE id and no longer carry `-preview` at all.
`resolveModelAlias`'s `hasKnownProviderModel` short-circuit is what stops the built-in
alias firing there — rewriting would dispatch an id those two no longer serve — which is
also why the alias entry stays for the other two rather than being dropped.
The loop asserted one outcome for all four. It now asserts both, split by which id the
provider serves, plus a case pinning the catalog premise itself so a future flip fails
with "which provider moved" instead of leaving the lifecycle assertions unexplained.
diegosouzapw
merged commit Aug 26, 2026
954d58b
into
cheaper-inference:release/v3.8.51
10 of 16 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 26, 2026
Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — #11580/#11582/#11583/#11585/#11588/#11589/#11590/#11591/#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… four (cheaper-inference#11590) Merged via /merge-batch (lote 2026-08-26, v3.8.51). Boarded no worktree combinado junto com outras ~30 PRs; validação única: typecheck/complexity/cognitive-complexity/changelog-integrity verdes, file-size rebaseado onde necessário (crescimento legítimo), lint com os mesmos 228 achados pré-existentes confirmados via sonda contra o tip puro (não introduzidos por este lote), e ~370 testes focados (unit + vitest) passando. Obrigado pela contribuição.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…per-inference#11608) Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — cheaper-inference#11580/cheaper-inference#11582/cheaper-inference#11583/cheaper-inference#11585/cheaper-inference#11588/cheaper-inference#11589/cheaper-inference#11590/cheaper-inference#11591/cheaper-inference#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the "every gate is red on every branch" cleanup — one of six independent unit-test failures on
release/v3.8.51.The red test
The test's premise expired halfway
Its docblock states the model "ships everywhere as
qwen3.8-max-preview(bailian-coding-plan, qoder, qwen-cloud-token-plan, qwen-web)". Probed against the live
catalogs and
hasKnownProviderModel:qwen3.8-maxresolveModelAlias(bare, provider)qwen-cloud-token-plan["qwen3.8-max"]qwen3.8-maxqwen-web["qwen3.8-max"]qwen3.8-maxqoder["qwen3.8-max-preview"]qwen3.8-max-previewbailian-coding-plan["qwen3.8-max-preview"]qwen3.8-max-previewTwo of the four now list the bare id and no longer carry
-previewat all.The code is right
resolveModelAliasshort-circuits the built-in alias when the provider serves the iditself:
Rewriting
qwen3.8-max→-previewon those two would dispatch an id they no longerserve — the mirror image of the 404 the original fix prevented. That short-circuit is
also why the
BUILT_IN_ALIASESentry correctly stays rather than being dropped: theother two still need it, and the alias map's own comment anticipated exactly this split
("Drop this line if Alibaba ever ships a distinct GA
qwen3.8-max").What changed
The loop asserted one outcome for all four providers, which the split made impossible to
express. It now asserts both directions, and adds a case pinning the catalog premise
itself:
So if a catalog flips again, the premise case fails first and names the provider that
moved, instead of leaving the lifecycle assertions failing with no explanation. The
docblock records the half-expiry rather than pretending the original premise still holds.
Verification
Test-only; no production code touched.