Skip to content

i18n(vi): translate the five reliability-column strings - #11589

Merged
diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.51from
ntdatt812:fix/i18n-vi-reliability-strings
Aug 26, 2026
Merged

diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.51from
ntdatt812:fix/i18n-vi-reliability-strings

Conversation

@ntdatt812

Copy link
Copy Markdown
Contributor

Part of the "every gate is red on every branch" cleanup — one of six independent unit-test failures on release/v3.8.51.

The red test

✖ Vietnamese locale has no internal missing markers or empty fallbacks

src/i18n/messages/vi.json carries five __MISSING__: placeholders, all from the
reliability column added to the free-provider rankings page:

key English
freeProviderRankingsPage.colReliability Reliability
freeProviderRankingsPage.colReliabilityHelp Share of calls this provider actually answered over the last 24 hours…
freeProviderRankingsPage.reliabilitySample {successes} of {requests} calls succeeded in the last {hours}h
freeProviderRankingsPage.reliabilityTooFew Only {requests} calls in the last {hours}h — too few to state a rate
freeProviderRankingsPage.reliabilityNoTraffic No calls recorded in the last 24h

A __MISSING__: marker is not a silent gap — it renders in the UI, so a Vietnamese
operator currently sees __MISSING__:Reliability as a column header.

The translation

Vietnamese is my first language. I matched the terminology already established in this
file rather than inventing new terms — nhà cung cấp for provider, hạn ngạch for
quota, the same register as the neighbouring colConfigured / filterAvailableOnlyHelp
strings.

"colReliability": "Độ tin cậy",
"colReliabilityHelp": "Tỷ lệ lệnh gọi mà nhà cung cấp này thực sự trả lời trong 24 giờ qua. Dấu gạch ngang nghĩa là lưu lượng quá ít để đưa ra tỷ lệ.",
"reliabilitySample": "{successes} trong {requests} lệnh gọi thành công trong {hours}h qua",
"reliabilityTooFew": "Chỉ có {requests} lệnh gọi trong {hours}h qua — quá ít để đưa ra tỷ lệ",
"reliabilityNoTraffic": "Không ghi nhận lệnh gọi nào trong 24h qua"

Every ICU placeholder is preserved verbatim — {successes}, {requests}, {hours} —
which the placeholder-parity and ICU-parse cases in the same suite check independently.

Verification

# base branch
✖ Vietnamese locale has no internal missing markers or empty fallbacks
ℹ tests 5  ℹ pass 4  ℹ fail 1

# with this change — the whole vi suite
✔ Vietnamese locale has complete key parity with English
✔ Vietnamese locale has no internal missing markers or empty fallbacks
✔ Vietnamese locale preserves every ICU placeholder name
✔ Vietnamese locale introduces no ICU parse regression
✔ no-auth provider controls keep locale translators unambiguous
ℹ tests 5  ℹ pass 5  ℹ fail 0

# every i18n suite in the repo
node … --test-concurrency=4 "tests/unit/i18n-*.test.ts"
ℹ tests 134  ℹ pass 134  ℹ fail 0

Locale-only; no code, no other locale touched.

`Unit Tests fast-path` is red on every branch:

    ✖ Vietnamese locale has no internal missing markers or empty fallbacks

`vi.json` carries five `__MISSING__:` placeholders, all from the reliability column
added to the free-provider rankings page:

    freeProviderRankingsPage.colReliability
    freeProviderRankingsPage.colReliabilityHelp
    freeProviderRankingsPage.reliabilitySample
    freeProviderRankingsPage.reliabilityTooFew
    freeProviderRankingsPage.reliabilityNoTraffic

Translated, matching the terminology the rest of the file already uses ("nhà cung cấp"
for provider, "hạn ngạch" for quota). Every ICU placeholder is preserved verbatim —
`{successes}`, `{requests}`, `{hours}` — which the placeholder-parity and ICU-parse
cases in the same suite check.
@diegosouzapw
diegosouzapw merged commit 91ede70 into cheaper-inference:release/v3.8.51 Aug 26, 2026
12 of 13 checks passed
diegosouzapw pushed a commit that referenced this pull request Aug 26, 2026
Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — #11580/#11582/#11583/#11585/#11588/#11589/#11590/#11591/#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…rence#11589)

Merged via /merge-batch (lote 2026-08-26, v3.8.51). Boarded no worktree combinado junto com outras ~30 PRs; validação única: typecheck/complexity/cognitive-complexity/changelog-integrity verdes, file-size rebaseado onde necessário (crescimento legítimo), lint com os mesmos 228 achados pré-existentes confirmados via sonda contra o tip puro (não introduzidos por este lote), e ~370 testes focados (unit + vitest) passando. Obrigado pela contribuição.
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…per-inference#11608)

Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). 7 conflitos, todos triviais/duplicados (mesmos base-reds já corrigidos por PRs paralelas mergeadas neste lote — cheaper-inference#11580/cheaper-inference#11582/cheaper-inference#11583/cheaper-inference#11585/cheaper-inference#11588/cheaper-inference#11589/cheaper-inference#11590/cheaper-inference#11591/cheaper-inference#11609): mantida a versão já validada nesses casos. Validado: 68/68 testes passando. Obrigado por resolver os base-reds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants