You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(api): GET /v1/combos should flag pinned accounts without leaking connectionId #10968
GET /v1/combos (API-key surface, #2300) projects only kind / model / providerId / comboName. connectionId is stripped on purpose and must stay stripped.
Consequence for operators who pin two accounts of the same provider (fill-first / priority failover):
Clients cannot tell “two pinned wallets” from “the same step duplicated”. Dashboard already shows acct <8-char> (ComboControlCenterClient). The public catalog has no equivalent boolean.
This is not a request to leak connectionId. A boolean (or count) is enough.
Steps to Reproduce
Create a combo with two model steps, same providerId + model, different pinned connectionIds.
GET /v1/combos with a normal API key.
Compare to the dashboard combo editor.
Expected Behavior
Public step includes something like accountPinned: true (or pinnedAccountCount on the combo) without the UUID.
Duplicate-looking steps with accountPinned: true are then distinguishable from a true duplicate of an unpinned step.
Actual Behavior
Two pinned accounts collapse to two identical {kind, model, providerId} objects. Integrations (OpenClaw, OpenCode plugin) conclude the combo has no failover.
Hi @RaviTharuma! Grounded and feasible — this is a clean XS addition.
Verified in the codebase: projectComboStep (src/app/api/v1/combos/projectCombo.ts) already reads raw step fields into PublicComboStep and deliberately drops connectionId; the raw step does carry a connectionId when an account is pinned (used by cleanupComboConnectionRefs in src/lib/db/combos.ts). So deriving accountPinned: boolean from a non-empty raw connectionId is a few lines and leaks nothing — no UUID, not even an 8-char prefix. Backward compatible (additive key).
Keep the existing connectionId-drop assertion in tests/unit/v1-combos-projection.test.ts green and add: accountPinned true for a pinned raw step, false for an unpinned one, and absent/false for combo-ref / malformed steps. Prefer the per-step accountPinned boolean over pinnedAccountCount on the combo — it directly disambiguates the duplicate-looking steps and matches the dashboard's per-step acct display.
Activity
diegosouzapw commentedon Aug 21, 2026
Hi @RaviTharuma! Grounded and feasible — this is a clean XS addition.
Verified in the codebase:
projectComboStep(src/app/api/v1/combos/projectCombo.ts) already reads raw step fields intoPublicComboStepand deliberately dropsconnectionId; the raw step does carry aconnectionIdwhen an account is pinned (used bycleanupComboConnectionRefsinsrc/lib/db/combos.ts). So derivingaccountPinned: booleanfrom a non-empty rawconnectionIdis a few lines and leaks nothing — no UUID, not even an 8-char prefix. Backward compatible (additive key).Keep the existing connectionId-drop assertion in
tests/unit/v1-combos-projection.test.tsgreen and add:accountPinnedtrue for a pinned raw step, false for an unpinned one, and absent/false for combo-ref / malformed steps. Prefer the per-stepaccountPinnedboolean overpinnedAccountCounton the combo — it directly disambiguates the duplicate-looking steps and matches the dashboard's per-step acct display.Status: ✅ Accepted — queued for implementation
feat(api): flag a pinned account on /v1/combos steps without leaking …
feat(api): flag a pinned account on /v1/combos steps without leaking …
feat(api): flag a pinned account on /v1/combos steps without leaking …