Don't apply default colors in the colors plugin when defaults are used#11927
Merged
LeeLenaleee merged 1 commit intochartjs:masterfrom Oct 13, 2024
Merged
Conversation
LeeLenaleee
changed the title
etimberg
approved these changes
Oct 13, 2024
8 tasks
|
Note that this fix relies on matching the string values being used on the This runs the risk of breaking if those strings ever change, even if the color values do not change, for example if spaces were added Chart.js/src/core/core.defaults.js Lines 38 to 42 in 79773b7 |
Collaborator
Author
|
I don't think that those values or formatting will change. And if it will change the test will break, so you need to revert it or update the colors plugin. So this should never break this fix unless the test is removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #11914