Add warning if filler plugin is used but not registered #10702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Sep 24, 2022
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Would it be sufficient to have the test in datasetController?
Also we could abstract the message, but that should be done if/when we get another similar warning.
Collaborator
Author
|
I thought only the dataset controller wasn't sufficient enough since it wouldn't throw an error when you set fill:true in the options. Downside of this is that if you specify fill true in the dataset and root of the options it will throw the warning multiple times |
Member
|
The dataset options should resolve to the root options, if not specified at dataset level, so it should work that way. Maybe add tests? :) |
Collaborator
Author
|
You are right 😅 , my 2AM testing brain was flawed so it seemed 😬 |
etimberg
approved these changes
Sep 26, 2022
kurkle
approved these changes
Sep 26, 2022
LeeLenaleee
deleted the
add-warning-on-using-filler-while-not-registering
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10700