Repository navigation
Commit 87dc319
API: Disallow strings in logical ufuncs (numpy#21024)
* API: Disallow strings in logical ufuncs
This restores pre 1.22 NumPy behaviour for strings passed into logical
ufuncs. Logical ufuncs should be able to cast inputs to booleans
without modifying their results.
Thus they do this now (in NumPy 1.22+). The problem is that string to
bool casts are very strange in NumPy currently.
This should be reverted/removed once string to bool casts are well
defined. But until then, it seems more reasonable to just reject
strings.
Closes numpygh-20898
Co-authored-by: Ross Barnowski <[email protected]>1 parent 593cc07 commit 87dc319
2 files changed
Lines changed: 23 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1018 | 1018 | | |
1019 | 1019 | | |
1020 | 1020 | | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
1021 | 1026 | | |
1022 | 1027 | | |
1023 | 1028 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2134 | 2134 | | |
2135 | 2135 | | |
2136 | 2136 | | |
2137 | | - | |
| 2137 | + | |
2138 | 2138 | | |
2139 | 2139 | | |
2140 | 2140 | | |
| |||
2150 | 2150 | | |
2151 | 2151 | | |
2152 | 2152 | | |
| 2153 | + | |
| 2154 | + | |
| 2155 | + | |
| 2156 | + | |
| 2157 | + | |
| 2158 | + | |
| 2159 | + | |
| 2160 | + | |
| 2161 | + | |
| 2162 | + | |
| 2163 | + | |
| 2164 | + | |
| 2165 | + | |
| 2166 | + | |
| 2167 | + | |
| 2168 | + | |
| 2169 | + | |
2153 | 2170 | | |
2154 | 2171 | | |
2155 | 2172 | | |
| |||
0 commit comments