Skip to content

charmc: make sure to link against pthread when using CkLoop#2778

Merged
matthiasdiener merged 2 commits intomasterfrom
ckloop-pthreads
Mar 26, 2020
Merged

charmc: make sure to link against pthread when using CkLoop#2778
matthiasdiener merged 2 commits intomasterfrom
ckloop-pthreads

Conversation

@matthiasdiener
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener commented Mar 25, 2020

Should help with issues such as the one seen here: spack/spack#15666 @s-sajid-ali

@matthiasdiener
charmc: make sure to link against pthread when using CkLoop
f0b54a3 
Should help with issues such as the one seen here: spack/spack#15666
@matthiasdiener matthiasdiener added the charmc The charmc build script label Mar 25, 2020
@matthiasdiener matthiasdiener added this to the 6.11 milestone Mar 25, 2020
@matthiasdiener matthiasdiener self-assigned this Mar 25, 2020
@matthiasdiener matthiasdiener mentioned this pull request Mar 25, 2020
Merged
@jcphill
Copy link
Copy Markdown
Collaborator

jcphill commented Mar 25, 2020

Does this work on Windows?

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

matthiasdiener commented Mar 25, 2020

Does this work on Windows?

That's a good point. Is CkLoop even supported on Windows? We could also restrict this to non-SMP mode (when pthreads is actually used).

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

matthiasdiener commented Mar 25, 2020

Does this work on Windows?

That's a good point. Is CkLoop even supported on Windows? We could also restrict this to non-SMP mode (when pthreads is actually used).

Fixed in the updated patch.

@evan-charmworks
Copy link
Copy Markdown
Contributor

evan-charmworks commented Mar 25, 2020

If you grep for pthread in src/arch, there is a lot of -lpthread. Should -pthread go there instead of charmc?

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

matthiasdiener commented Mar 25, 2020

If you grep for pthread in src/arch, there is a lot of -lpthread. Should -pthread go there instead of charmc?

These seem to be mostly for SMP support. The issue here is that we need pthread for non-SMP mode, but only when using CkLoop. I think putting this in multiple src/arch files would cause lots of duplication there.

@matthiasdiener matthiasdiener merged commit b22970e into master Mar 26, 2020
@matthiasdiener matthiasdiener deleted the ckloop-pthreads branch May 11, 2020 22:47
stwhite91 pushed a commit that referenced this pull request May 11, 2023
@matthiasdiener @stwhite91
charmc: make sure to link against pthread when using CkLoop (#2778)
3f86997 
* charmc: make sure to link against pthread when using CkLoop

Should help with issues such as the one seen here: spack/spack#15666

* dont link when SMP or Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stwhite91 stwhite91 stwhite91 approved these changes

@evan-charmworks evan-charmworks evan-charmworks approved these changes

@jcphill jcphill Awaiting requested review from jcphill

Assignees

@matthiasdiener matthiasdiener

Labels

charmc The charmc build script

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@matthiasdiener @jcphill @evan-charmworks @stwhite91