fix: Add missing id initialization in field_select constructor#692
Merged
andreynering merged 1 commit intocharmbracelet:mainfrom Sep 22, 2025
Merged
fix: Add missing id initialization in field_select constructor#692andreynering merged 1 commit intocharmbracelet:mainfrom
andreynering merged 1 commit intocharmbracelet:mainfrom
Conversation
forever-salty
requested review from
andreynering and
meowgorithm
and removed request for
a team
|
@meowgorithm / @andreynering any chance one of you can review and merge? It makes huh forms with multiple select elements unusable. Thanks! |
caarlos0
approved these changes
Sep 22, 2025
andreynering
approved these changes
Sep 22, 2025
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
Hi @forever-salty, thank you for contributing!
I confirm your fix is working properly.
jonas-grgt
pushed a commit
to jonas-grgt/huh
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This fixes the field_select constructor to properly set the field's id.
Related issue/discussion: #691
Checklist before requesting a review
CONTRIBUTING.md