Skip to content

fix: group varying heights#350

Merged
bashbunni merged 2 commits intomainfrom
fix/group-varying-heights
Aug 3, 2024
Merged

fix: group varying heights#350
bashbunni merged 2 commits intomainfrom
fix/group-varying-heights

Conversation

@bashbunni
Copy link
Copy Markdown
Contributor

  • chore: add example of multiple groups with varying heights
  • fix(multiselect): set viewport height in initial render

@bashbunni bashbunni requested a review from maaslalani as a code owner August 2, 2024 23:23
@bashbunni bashbunni linked an issue Aug 2, 2024 that may be closed by this pull request
@bashbunni bashbunni merged commit 2eb851f into main Aug 3, 2024
@bashbunni bashbunni deleted the fix/group-varying-heights branch August 3, 2024 00:00
renovate bot referenced this pull request in jippi/dottie Aug 23, 2024
….mod (#85)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/charmbracelet/huh](https://togithub.com/charmbracelet/huh)
| `v0.5.2` -> `v0.5.3` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcharmbracelet%2fhuh/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcharmbracelet%2fhuh/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcharmbracelet%2fhuh/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcharmbracelet%2fhuh/v0.5.2/v0.5.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charmbracelet/huh (github.com/charmbracelet/huh)</summary>

###
[`v0.5.3`](https://togithub.com/charmbracelet/huh/releases/tag/v0.5.3)

[Compare
Source](https://togithub.com/charmbracelet/huh/compare/v0.5.2...v0.5.3)

### Crushin’ bugs

This release fixes a buncha bugs in Huh and
[Gum](https://togithub.com/charmbracelet/gum) alike. Gum users, stay
tuned for an update later today.

#### What's Changed

##### Fixed

- fix: group varying heights by
[@&#8203;bashbunni](https://togithub.com/bashbunni) in
[https://github.com/charmbracelet/huh/pull/350](https://togithub.com/charmbracelet/huh/pull/350)
- fix: group size when height is 0 by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/363](https://togithub.com/charmbracelet/huh/pull/363)
- fix(filepicker): not closing on close by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/323](https://togithub.com/charmbracelet/huh/pull/323)
- fix(select): wrapping selects by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/324](https://togithub.com/charmbracelet/huh/pull/324)
- fix(select): select all/none by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/325](https://togithub.com/charmbracelet/huh/pull/325)
- fix(multiselect): contextual 'select all' help text by
[@&#8203;meowgorithm](https://togithub.com/meowgorithm) in
[https://github.com/charmbracelet/huh/pull/342](https://togithub.com/charmbracelet/huh/pull/342)
- fix(spinner): light color in title by
[@&#8203;hyorigo](https://togithub.com/hyorigo) in
[https://github.com/charmbracelet/huh/pull/346](https://togithub.com/charmbracelet/huh/pull/346)
- fix (multiselect): set filterable not working by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/335](https://togithub.com/charmbracelet/huh/pull/335)
- fix(lint): golangci-lint issues by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/378](https://togithub.com/charmbracelet/huh/pull/378)

#### Other Stuff

- chore: update codeowners by
[@&#8203;caarlos0](https://togithub.com/caarlos0) in
[https://github.com/charmbracelet/huh/pull/379](https://togithub.com/charmbracelet/huh/pull/379)
- refactor: use a selector type to select items by
[@&#8203;aymanbagabas](https://togithub.com/aymanbagabas) in
[https://github.com/charmbracelet/huh/pull/328](https://togithub.com/charmbracelet/huh/pull/328)
- refactor: make item selector into a slice container by
[@&#8203;aymanbagabas](https://togithub.com/aymanbagabas) in
[https://github.com/charmbracelet/huh/pull/334](https://togithub.com/charmbracelet/huh/pull/334)

#### New Contributors

- [@&#8203;bashbunni](https://togithub.com/bashbunni) made their first
contribution in
[https://github.com/charmbracelet/huh/pull/350](https://togithub.com/charmbracelet/huh/pull/350)
- [@&#8203;hyorigo](https://togithub.com/hyorigo) made their first
contribution in
[https://github.com/charmbracelet/huh/pull/346](https://togithub.com/charmbracelet/huh/pull/346)

**Full Changelog**:
charmbracelet/huh@v0.5.2...v0.5.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* */1 * * *" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/jippi/dottie).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi select viewport height not set on initial render

1 participant