Repository navigation
feat: add max_wait_time parameter to job_output tool - #1496
Closed
heimoshuiyu wants to merge 1 commit into
Closed
heimoshuiyu wants to merge 1 commit into
heimoshuiyu wants to merge 1 commit into
Conversation
Allow job_output tool to wait for job completion with configurable timeout. The tool now supports a max_wait_time parameter that enables monitoring long-running tasks without continuous polling. When the timeout is reached, it provides helpful feedback suggesting a longer wait time.
heimoshuiyu
requested review from
aymanbagabas and
meowgorithm
and removed request for
a team
November 22, 2025 05:15
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
andreynering
reviewed
Feb 4, 2026
Member
There was a problem hiding this comment.
We recently released a complete UI rewrite to improve performance and maintainability.
The new code is on internal/ui as opposed to internal/tui. So you'll need to undo these changes and reimplement this part on internal/ui.
Member
|
Thank you for your contribution! This pull request has merge conflicts and has had no activity for over 2 months, so we are closing it to keep the queue manageable. If you would still like to get this merged, please rebase onto the latest main branch and reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow job_output tool to wait for job completion with configurable timeout. The tool now supports a max_wait_time parameter that enables monitoring long-running tasks without continuous polling. When the timeout is reached, it provides helpful feedback suggesting a longer wait time.
CONTRIBUTING.md.This should not be considered a feature, but rather a fix. It prevents the crush from repeatedly calling job_output within a short period to check if the task is completed.
In YOLO mode, the crush sent over 20 requests in one minute to check if the compilation task was finished, and the repeated tool calls quickly exceeded the model's context limit. This is a serious issue.
Adding a maximum wait time parameter can resolve this problem.