Repository navigation
fix: add prepublishOnly guard to run tests before npm publish - #3
Merged
charlietlamb merged 1 commit intoMar 18, 2026
Merged
Conversation
Currently the bump and patch scripts run npm publish directly without any validation. This means a broken build can be published to npm if tests are not run manually beforehand. Adding prepublishOnly lifecycle hook ensures bun test runs automatically before every npm publish, preventing broken releases from reaching users. Co-Authored-By: seungwoolee <[email protected]>
|
@lifrary is attempting to deploy a commit to the charlietlamb's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Owner
|
LGTM - Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently
bumpandpatchscripts executenpm publishdirectly without any pre-publish validation:If tests happen to be failing at the time of publish, a broken package can still be released to npm. This is easy to miss especially when iterating quickly during beta.
Solution
Add a
prepublishOnlylifecycle hook that runsbun testbefore everynpm publish:prepublishOnlyis an npm lifecycle script that runs automatically beforenpm publishand beforenpm pack. If tests fail, the publish is aborted — no manual step needed.What changes
packages/ol/package.json: Added"prepublishOnly": "bun test"to scriptsHow it works
Both
bumpandpatchscripts will now be guarded automatically since they both callnpm publishinternally.Testing
Verified locally:
npm publish --dry-runtriggersprepublishOnlyand runsbun testas expectedSummary by cubic
Add
prepublishOnlyto runbun testbefore everynpm publish, so publishes abort if tests fail. This guards bothbumpandpatchflows inpackages/olto prevent broken releases.Written for commit c2bda75. Summary will update on new commits.