restructure __internals to shave bytes; add react tests#82
Merged
Conversation
Owner
Author
|
This has a bug that react won't update because the array refs won't change |
charkour
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not considered a breaking change because it relied on undocumented internal APIs that were potentially accessed in userland.
937 B --> 898 B (Saves 39 bytes)
898 B --> 871 B (Saves 27 bytes) should also improve the speed because we aren't creating new arrays (less GC)871 B --> 862 B (Saves 9 bytes) should also improve the speed because we aren't creating new arrays (less GC)898 B --> 880 B (saves 18 bytes) add back copying arrays to make sure reactivity stays in place
880 --> 873 B (saves 7 bytes) remove object destructuring in __handleUserSet
873 B --> 870 B (saves 3 bytes) don't spread options from user
870 B --> 868 B (saves 2 bytes) don't destructure