Conversation
|
Looks cool! What is junit? |
|
@charkour In general junit is a report of your test cases written in XML which is supported by most test runners. I added an action which will read that junit file (generated from vitest) and then should display a summary in the PR. It's totally optional though My main motivation was simply to run the test & build during the Pipeline so you don't need to checkout PRs locally to verify whether the tests work |
|
That's awesome! We can give it a go! Never got around to adding the action back so this will be nice. Are the results supposed to add a comment somewhere? |
|
@charkour hmm seems like it doesn't have sufficient permissions -- maybe because I am on a fork. It's up to you whether you wanna go after it -- it will be hard from my side to fix this since I am not the repo owner. You can also simply delete that step if it's not useful or too much effort to get it working. I believe the main merit here is that the build/test at least runs through! EDIT: Ah found it here. I guess you'd need to create a Personal Access Token, and store it as a variable within this repositories actions variables. This will be the result if it works: |
|
Awesome, I've added a PAT to this repo. Looks like there might need to be two workflows. One for the test and another to publish the results. The secret is called Is this something you'd like to work on @BrunnerLivio? |
584e539 to
b3cf885
Compare
b3cf885 to
59a860b
Compare
|
@charkour I was unfortunately unable to get it working with the report, but at least a more basic pipeline runs through nicely. I also added a matrix build for node v14,v16,18 |
|
Sounds good! I like the testing matrix. The documentation for jUnit isn't super great. But for the commenting to work, it looks there two Workflows need to be run. |
charkour
left a comment
There was a problem hiding this comment.
Would you be willing to add the junit.xml file to the .gitignore?
Then I think this is good to go
charkour
left a comment
There was a problem hiding this comment.
oops I meant to request changes for this!
|
@charkour Oups, that file was meant to be deleted anyway. Not needed to be added to gitignore since it won't get generated anymore! |
|
Thank you! |
charkour
left a comment
There was a problem hiding this comment.
Will be nice to run tests before merging. Thanks!

:)