Merged
Conversation
BrunnerLivio
force-pushed
the
fix/zustand-support-4.3.x
branch
from
5f253bf to
ebe1f18
Compare
Owner
|
I'll get to this in about 3 hours. Thank you so much for the PR! |
charkour
reviewed
Jan 11, 2023
| config: StateCreator<TState, [], []>, | ||
| options: ZundoOptions<TState>, | ||
| ) => PopArgument<StateCreator<TState, [], []>>; | ||
| ) => StateCreator<TState, [], []>; |
Owner
There was a problem hiding this comment.
Can you explain this change here?
Owner
There was a problem hiding this comment.
I see here that this is actually not needed. Thanks!
charkour
approved these changes
Jan 11, 2023
Owner
charkour
left a comment
charkour
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix! Wasn't expecting zustand v4.3.0 to break this much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62
I am honestly new to Zundo (I just downloaded it 1 hour ago) and also not really an expert when it comes to Zustand as well 😅
The changelogs are quite insightful if you wanna double check things. Though really unexpected changes for a supposedly "minor" release...
I was able to make the tests all green without major modifications and I quickly double checked whether it works in my application via
npm linkand it works all fine. Though I use Zundo in its most basic form so maybe you need to double check the more advanced usecase of this lib