Skip to content

[schema] Update askbot.csv#812

Merged
valeriocos merged 1 commit intochaoss:masterfrom
vchrombie:update-askbot-schema
Mar 22, 2020
Merged

[schema] Update askbot.csv#812
valeriocos merged 1 commit intochaoss:masterfrom
vchrombie:update-askbot-schema

Conversation

@vchrombie
Copy link
Copy Markdown
Member

@vchrombie vchrombie commented Mar 20, 2020 •
edited
Loading

This PR updates the askbot schema to the latest format.
Reference to #803

@vchrombie
Copy link
Copy Markdown
Member Author

vchrombie commented Mar 20, 2020 •
edited
Loading

Hi @valeriocos
As of now, I have updated the fields and the aggregatable column.

I need to add the description yet.

I will squash all the commits once I am done with the PR.
Thanks.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2034

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.758%
Totals Coverage Status
Change from base Build 2032: 0.0%
Covered Lines: 7044
Relevant Lines: 9298
💛 - Coveralls

valeriocos
valeriocos reviewed Mar 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vchrombie, I left just a minor comment. Would be possible to add the description of each field (something similar to https://github.com/chaoss/grimoirelab-elk/blob/master/schema/github2_issues.csv)?

Please note that:

  • some descriptions can be taken from existing CSVs
  • if you think that's too much work we can merge this PR and work on another PR to add the descriptions.

Thanks

Comment thread schema/askbot.csv
@vchrombie
Copy link
Copy Markdown
Member Author

vchrombie commented Mar 21, 2020

Hi @valeriocos

Would be possible to add the description of each field (something similar to https://github.com/chaoss/grimoirelab-elk/blob/master/schema/github2_issues.csv)?

  • some descriptions can be taken from existing CSVs

Yes, I will do that. I was waiting for your approval in the procedure. Also, thanks for the suggestion. I will update you on the PR.

  • if you think that's too much work we can merge this PR and work on another PR to add the descriptions.

Not really, I can push commits to this PR. Once everything is in good shape, I can squash and later we can merge.

@valeriocos
Copy link
Copy Markdown
Member

valeriocos commented Mar 21, 2020

Thanks @vchrombie ! Ping me when the PR is ready!

@vchrombie vchrombie force-pushed the update-askbot-schema branch 4 times, most recently from d88c056 to 8af3549 Compare March 21, 2020 21:54
@vchrombie
Copy link
Copy Markdown
Member Author

vchrombie commented Mar 21, 2020

Hi @valeriocos
The askbot schema is completed. It is ready for review.
It has 3 commits as of now.

  1. 41f05c9, which updates all the fields with the latest index
  2. 17d2ec6, which updates the aggregatable column of the fields
  3. 8af3549, which updates the description column of the field (this might need a review 😅 )

Please review it when you are free. After the PR is approved, I will squash all these commits into 1.
Thanks. 🙂

valeriocos
valeriocos reviewed Mar 22, 2020
View reviewed changes
Comment thread schema/askbot.csv Outdated
valeriocos
valeriocos approved these changes Mar 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vchrombie . I left a really minor comment.

Please squash the commits in one and ping me when the PR is ready to be merged. Thanks!

@vchrombie
[schema] Update askbot.csv
d5f50a4 
This commit updates the fields of the askbot schema and
updates the schema to the latest format by adding aggregatable
and description columns to the fields.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie vchrombie force-pushed the update-askbot-schema branch from 8af3549 to d5f50a4 Compare March 22, 2020 11:00
@vchrombie
Copy link
Copy Markdown
Member Author

vchrombie commented Mar 22, 2020 •
edited
Loading

Hi @valeriocos
Thanks for the suggestion, updated the PR.

I have squashed the commits too. Please let me know if there are any more changes to do. 🙂

@valeriocos
Copy link
Copy Markdown
Member

valeriocos commented Mar 22, 2020

Thank you @vchrombie !

@valeriocos valeriocos merged commit 65f6fde into chaoss:master Mar 22, 2020
@vchrombie vchrombie deleted the update-askbot-schema branch May 26, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@valeriocos valeriocos valeriocos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchrombie @coveralls @valeriocos