Repository navigation
Fix: Changes not detected by changeset cli 2.23.1 - #871
Conversation
Not include ignore.
🦋 Changeset detectedLatest commit: e34da75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e34da75:
|
| const changePackagesName = changedPackages | ||
| .map(pkg => pkg.packageJson.name) | ||
| .filter(pkgName => config.ignore.includes(pkgName)); | ||
| .filter(pkgName => !config.ignore.includes(pkgName)); |
| .filter(pkgName => config.ignore.includes(pkgName)); | ||
| .filter(pkgName => !config.ignore.includes(pkgName)); | ||
|
|
||
| newChangeset = await createChangeset(changePackagesName, packages); |
There was a problem hiding this comment.
Is this line correct? Could you check this as well?
Because I got an error below
$ /Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/.bin/changeset
🦋 error TypeError: Cannot read properties of undefined (reading 'packageJson')
🦋 error at createChangeset (/Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/@changesets/cli/dist/cli.cjs.dev.js:415:75)
🦋 error at add (/Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/@changesets/cli/dist/cli.cjs.dev.js:507:26)
🦋 error at async run$2 (/Users/ms.park/Desktop/workspace/payment.ohou.se/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1254:5)
error Command failed with exit code 1.
And this error is from this line.
This line was originally same with before
newChangeset = await createChangeset(changePackagesName, packages.packages);
But this had been changed since 2.23.1
There was a problem hiding this comment.
With what version do you experience this problem? With the 2.23.1 or with the version of the code from this PR?
Not include ignore.