Conversation
|
Hooray! All contributors have signed the CLA. |
🦋 Changeset detectedLatest commit: 3c9c9ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Overall looks good but I have a few questions:
And we, of course, need at least a basic test that would verify this. |
|
@Andarist I'd like to 👍 this and potentially offer to help if I'm able. I haven't actually looked over the PR yet, so pardon any assumptions. We currently use lerna + verdaccio in a pretty sophisticated CI workflow in order to "capture" the result of a publish and save the published tarballs as an artifact. This allows us to So my hope for a feature like this is that the tarballs are packed and usable (in order to save as an artifact in CI). Does this seem feasible? |
I think this feature wouldn't quite be what Where are those tarballs that you are mentioning published? What's the target for those packed artifacts? I think it would be great to open a separate issue for this. |
|
@Andarist I think you're right...there may be some relatedness in implementation to what I'm asking for, but what I'm asking for is definitely different. What I'm looking for is the As for our workflow: the tarballs are currently published as an artifact in our CircleCI jobs for every PR / push. If by target you mean "how are they used", I can visit the CI job's artifacts tab, grab a url for a particular package's tarball, and Here's an example of a particular build's artifacts for Apollo's If I copy link address for a tarball, I can just: I'll open a separate issue and bring along all of this context there 👍 |
|
@trevor-scheer I have some minor follow-up questions but I'm going to wait for that issue to ask them - just so we can get a clean history for this feature request and all of the context in one place. |
|
I forgot I created this PR! I'll dust it off soon and start addressing feedback. Thank you all for your feedback. |
|
@steve-taylor is this still in the works? |
Co-authored-by: Mateusz Burzyński <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c9c9ab:
|
@silesky Yes, I finally dusted off the cobwebs and updated it. I'll test it a bit more locally then mark it as ready for review. |
NPM:
PNPM with
The |
@Andarist I added some tests, but I'm not sure if it's what you had in mind. |
|
Test: I think the 401 error is expected in this case. Nothing was published, of course. The only issue is that the |
|
Any way to get this over the finish line? |
|
any plans to merge this PR? |
|
Sorry to be the one that does the annoying "bump" messages, but would be great to land this work. 🙏 This feature of npm would be super valuable when testing CI/CD integrations that leverage the output from publishing. In that scenario, we don't want to actually publish anything but we need the resulting output to send some notification after publishing (e.g. send the names of the published packages to Slack after the publication is complete). It looks like @steve-taylor added the avoidance of creating a git tag as well (great catch!), and now it should be possible to repeatedly call Thanks for everyone's work on this! |
|
Came looking for this feature. Will it ever happen? |
|
I know many of you are watching this PR - I'd like to get more info about the need for this option. If you care about this, please join the discussion here: #614 (comment) |
|
Any plans to get this merged? |
This fixes #614.
When publishing with the
--dry-runoption--dry-runis passed tonpm publishorpnpm publishgit tagisn't called.However, the release plan will be applied, so you can locally inspect the changes it would have made in a real package publication scenario.