Skip to content

Consistently use the repository's preferred package manager - #2097

Merged
Andarist merged 79 commits into
mainfrom
use-host-package-manager
Jul 16, 2026
Merged

Andarist merged 79 commits into
mainfrom
use-host-package-manager

Conversation

@Andarist

@Andarist Andarist commented Jun 14, 2026 •

Copy link
Copy Markdown
Member

fixes #432
fixes #1454
fixes #598
fixes #813
fixes #1411

@changeset-bot

changeset-bot Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0028822

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist
Andarist force-pushed the simplify-auth-flow branch 2 times, most recently from 7cdb754 to 3b9c86b Compare June 23, 2026 21:22
Base automatically changed from simplify-auth-flow to main June 29, 2026 10:01
@Andarist
Andarist force-pushed the use-host-package-manager branch from bd3c4f5 to 07ccfb0 Compare July 1, 2026 11:33
@codecov

codecov Bot commented Jul 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.69710% with 228 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.27%. Comparing base (162419d) to head (0028822).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/cli/src/ponyfills/async-disposable-stack.ts 3.33% 50 Missing and 8 partials ⚠️
packages/cli/src/commands/publish/npm-utils.ts 59.45% 40 Missing and 5 partials ⚠️
packages/cli/src/utils/package-manager-errors.ts 31.14% 33 Missing and 9 partials ⚠️
packages/cli/src/commands/__tests__/e2e-utils.ts 80.00% 30 Missing and 4 partials ⚠️
packages/cli/src/commands/pack/index.ts 51.11% 21 Missing and 1 partial ⚠️
...ckages/cli/src/commands/publish/publishPackages.ts 26.31% 13 Missing and 1 partial ⚠️
packages/cli/src/utils/streamNdjson.ts 0.00% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
- Coverage   88.24%   82.27%   -5.98%     
==========================================
  Files          72       76       +4     
  Lines        2604     3024     +420     
  Branches      698      845     +147     
==========================================
+ Hits         2298     2488     +190     
- Misses        283      485     +202     
- Partials       23       51      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy bluwy left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I understood every edge case and pm-specific handling, but I trust that this is handled well with the e2e tests 😄 And the logic seems good for me.

Also, we need changesets here.

@Andarist
Andarist requested a review from bluwy July 15, 2026 08:40
@Andarist
Andarist added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 8c88f6a Jul 16, 2026
10 of 12 checks passed
@Andarist
Andarist deleted the use-host-package-manager branch July 16, 2026 08:40
@jperezrealini

Copy link
Copy Markdown

Will these changes help solve this issue? #1468

@Andarist

Copy link
Copy Markdown
Member Author

@jperezrealini not yet - but we'll work on Bun support soon. This PR and #2155 prepare the groundwork for that

cursor Bot pushed a commit to thilllon/pixid that referenced this pull request Aug 26, 2026
Switch the release workflow to npm trusted publishing:

- Add id-token: write so the job can mint a GitHub OIDC token.
- Drop the 'skip when NPM_TOKEN is empty' guard: the Version Packages PR
  and OIDC publishes need no secret. NPM_TOKEN stays wired through as a
  fallback only.
- Keep changesets/action with 'publish: pnpm release' unchanged. The
  publish path is OIDC-capable end to end: @changesets/cli v3 routes the
  actual publish through the detected package manager
  (changesets/changesets#2097), i.e. 'pnpm publish' per package, and
  pnpm 11 implements the npm OIDC token exchange natively, preferring it
  over any static _authToken (pnpm/pnpm#11495). So no restructuring to
  'pnpm -r publish' is needed and changesets keeps handling tags,
  GitHub releases, and skip-already-published logic.
- No npm CLI upgrade step: the npm >= 11.5.1 trusted-publishing minimum
  is met by node 24's bundled npm (11.17.0 today), and npm is not on the
  publish path anyway since pnpm performs the publish itself.
- No registry-url on setup-node: it would write an .npmrc token
  placeholder that shadows OIDC (npm/cli#8730).

Publishing succeeds once a trusted publisher (owner thilllon, repo
pixid, workflow release.yml) is configured on npmjs.com per package.
Trusted publishing cannot create a brand-new package, so the unscoped
'pixid' needs a one-time manual/token first publish before its trusted
publisher can be configured; until then the publish step fails on that
package only.

Co-authored-by: thilllon <[email protected]>
@tuler tuler mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg.pr.new Publish PR via pkg.pr.new pnpm yarn

Projects

None yet

5 participants