Update js-yaml to v4 - #1772

🦋 Changeset detected

Latest commit: 896cc50

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.09%. Comparing base (60512b5) to head (896cc50).
⚠️ Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
+ Coverage   81.05%   81.09%   +0.04%     
==========================================
  Files          54       54              
  Lines        2264     2264              
  Branches      684      684              
==========================================
+ Hits         1835     1836       +1     
+ Misses        424      423       -1     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andarist FYI this doesn't fully fix the issue.

Also need to update read-yaml-file to v2.

[email protected] still depends on js-yaml@3

🦋  error Error: Function yaml.safeLoad is removed in js-yaml 4. Use yaml.load instead, which is now safe by default.
🦋  error     at Object.safeLoad (/.../node_modules/.pnpm/[email protected]/node_modules/js-yaml/index.js:10:11)
🦋  error     at parse (/.../node_modules/.pnpm/[email protected]/node_modules/read-yaml-file/index.js:8:28)
🦋  error     at /.../node_modules/.pnpm/[email protected]/node_modules/read-yaml-file/index.js:10:71

read-yaml-file is a dependency of @manypkg/get-packages.
I'll try to up date to v2.
v3 doesn't provide cjs files so this might be a problem since main branch is still relying on jest@29.

To share, I confirm overriding read-yaml-file to v2 does fix the issue.

So if there is still problem due to @manypkg/get-packages after the additional fix, there is a workaround.

To be clear I was speaking about upgrading @manypkg/get-packages not read-yaml-file 😅

On mobile, but there's an issue/pr about upgrading the get-packages dependency that you should search for first. I think we cant upgrade it in this major due to its breaking change.

there's an issue/pr about upgrading the get-packages dependency that you should search for first

I tackled an hour and I was able to get CI green using @manypkg/get-packages@2.
I've opened #1795, if you have time you can take a look!